Merge pull request cli#428 from vertextau/oauth-fix

Nate Smith · web-flow · commit 10ea161f9281 · 2020-02-14T10:20:22.000-06:00
Improve randomString function
diff --git a/auth/oauth.go b/auth/oauth.go
@@ -2,6 +2,7 @@ package auth
 
 import (
 	"crypto/rand"
+	"encoding/hex"
 	"errors"
 	"fmt"
 	"io"
@@ -20,7 +21,7 @@ func randomString(length int) (string, error) {
 	if err != nil {
 		return "", err
 	}
-	return fmt.Sprintf("%x", b), nil
+	return hex.EncodeToString(b), nil
 }
 
 // OAuthFlow represents the setup for authenticating with GitHub

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package auth`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"crypto/rand"`
	`5`	`+ "encoding/hex"`
`5`	`6`	`"errors"`
`6`	`7`	`"fmt"`
`7`	`8`	`"io"`
`@@ -20,7 +21,7 @@ func randomString(length int) (string, error) {`
`20`	`21`	`if err != nil {`
`21`	`22`	`return "", err`
`22`	`23`	`}`
`23`		`- return fmt.Sprintf("%x", b), nil`
	`24`	`+ return hex.EncodeToString(b), nil`
`24`	`25`	`}`
`25`	`26`
`26`	`27`	`// OAuthFlow represents the setup for authenticating with GitHub`