refactor: code cleanup incorporating the PR suggestions and removed blank lines

sibis · sibis · commit 0fc9dfac37f1 · 2020-03-12T00:44:07.000+05:30
diff --git a/command/repo.go b/command/repo.go
@@ -386,20 +386,16 @@ var Confirm = func(prompt string, result *bool) error {
 
 func repoView(cmd *cobra.Command, args []string) error {
 	ctx := contextForCommand(cmd)
-
-	var openURL string
 	var toView ghrepo.Interface
 	if len(args) == 0 {
-		baseRepo, err := determineBaseRepo(cmd, ctx)
+		var err error
+		toView, err = determineBaseRepo(cmd, ctx)
 		if err != nil {
 			return err
 		}
-		openURL = fmt.Sprintf("https://github.com/%s", ghrepo.FullName(baseRepo))
-		toView = baseRepo
 	} else {
 		repoArg := args[0]
 		if isURL(repoArg) {
-			openURL = repoArg
 			parsedURL, err := url.Parse(repoArg)
 			if err != nil {
 				return fmt.Errorf("did not understand argument: %w", err)
@@ -411,23 +407,19 @@ func repoView(cmd *cobra.Command, args []string) error {
 			}
 		} else {
 			toView = ghrepo.FromFullName(repoArg)
-			openURL = fmt.Sprintf("https://github.com/%s", repoArg)
 		}
 	}
 
 	apiClient, err := apiClientForContext(ctx)
-
 	if err != nil {
 		return err
 	}
-
-	_, err_message := api.GitHubRepo(apiClient, toView)
-	if err_message != nil {
-		return err_message
+	_, err = api.GitHubRepo(apiClient, toView)
+	if err != nil {
+		return err
 	}
 
+	openURL := fmt.Sprintf("https://github.com/%s", ghrepo.FullName(toView))
 	fmt.Fprintf(cmd.ErrOrStderr(), "Opening %s in your browser.\n", displayURL(openURL))
 	return utils.OpenInBrowser(openURL)
-
-	
 }
diff --git a/command/repo_test.go b/command/repo_test.go
@@ -610,7 +610,6 @@ func TestRepoView(t *testing.T) {
 	eq(t, url, "https://github.com/OWNER/REPO")
 }
 
-
 func TestRepoView_ownerRepo(t *testing.T) {
 	ctx := context.NewBlank()
 	ctx.SetBranch("master")

Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,6 @@ func TestRepoView(t *testing.T) {`
`610`	`610`	`eq(t, url, "https://github.com/OWNER/REPO")`
`611`	`611`	`}`
`612`	`612`
`613`		`-`
`614`	`613`	`func TestRepoView_ownerRepo(t *testing.T) {`
`615`	`614`	`ctx := context.NewBlank()`
`616`	`615`	`ctx.SetBranch("master")`