small repo fix

vilmibm · vilmibm · commit 08e9cdaee18d · 2020-05-15T10:25:40.000-05:00
diff --git a/command/root.go b/command/root.go
@@ -223,17 +223,16 @@ func determineBaseRepo(apiClient *api.Client, cmd *cobra.Command, ctx context.Co
 		return ghrepo.FromFullName(repo), nil
 	}
 
-	baseOverride, err := cmd.Flags().GetString("repo")
-	if err != nil {
-		return nil, err
-	}
+	// TODO check to see if the git config has a default repo set; if it seems like an interactive
+	// environment, ask which of the resolved remotes the user wants to use as the base. if none, let
+	// them type one in. save in git config and then skip git resolution next time.
 
 	remotes, err := ctx.Remotes()
 	if err != nil {
 		return nil, err
 	}
 
-	repoContext, err := context.ResolveRemotesToRepos(remotes, apiClient, baseOverride)
+	repoContext, err := context.ResolveRemotesToRepos(remotes, apiClient, "")
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -223,17 +223,16 @@ func determineBaseRepo(apiClient api.Client, cmd cobra.Command, ctx context.Co`
`223`	`223`	`return ghrepo.FromFullName(repo), nil`
`224`	`224`	`}`
`225`	`225`
`226`		`- baseOverride, err := cmd.Flags().GetString("repo")`
`227`		`- if err != nil {`
`228`		`- return nil, err`
`229`		`- }`
	`226`	`+ // TODO check to see if the git config has a default repo set; if it seems like an interactive`
	`227`	`+ // environment, ask which of the resolved remotes the user wants to use as the base. if none, let`
	`228`	`+ // them type one in. save in git config and then skip git resolution next time.`
`230`	`229`
`231`	`230`	`remotes, err := ctx.Remotes()`
`232`	`231`	`if err != nil {`
`233`	`232`	`return nil, err`
`234`	`233`	`}`
`235`	`234`
`236`		`- repoContext, err := context.ResolveRemotesToRepos(remotes, apiClient, baseOverride)`
	`235`	`+ repoContext, err := context.ResolveRemotesToRepos(remotes, apiClient, "")`
`237`	`236`	`if err != nil {`
`238`	`237`	`return nil, err`
`239`	`238`	`}`