Skip to content

Commit 036d26a

Browse files
author
nate smith
committed
oops
1 parent 840f93b commit 036d26a

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

script/sign-windows-executable.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,13 @@ curl \
77
-H "Authorization: token $DESKTOP_CERT_TOKEN" \
88
-H "Accept: application/vnd.github.v3.raw" \
99
--output windows-certificate.pfx \
10-
#--silent \
1110
https://api.github.com/repos/desktop/desktop-secrets/contents/windows-certificate.pfx
1211

1312
PROGRAM_NAME="GitHub CLI"
1413

1514
# Convert private key to the expected format
1615
openssl pkcs12 -in windows-certificate.pfx -nocerts -nodes -out private-key.pem -passin pass:${GITHUB_CERT_PASSWORD}
17-
openssl rsa -in private-key.pem -outform PVK -pvk-none -out private-key.pvk # 2>/dev/null # Always writes to STDERR
16+
openssl rsa -in private-key.pem -outform PVK -pvk-none -out private-key.pvk
1817

1918
# Convert certificate chain into the expected format
2019
openssl pkcs12 -in windows-certificate.pfx -nokeys -nodes -out certificate.pem -passin pass:${GITHUB_CERT_PASSWORD}
@@ -26,5 +25,4 @@ signcode \
2625
-n $PROGRAM_NAME \
2726
-t http://timestamp.digicert.com \
2827
-a sha256 \
29-
$EXECUTABLE_PATH # \
30-
# 1 > /dev/null # STDOUT a little bit chatty here, with multiple lines
28+
$EXECUTABLE_PATH

0 commit comments

Comments
 (0)