Add pr list --search

mislav · mislav · commit 01bbb15b5711 · 2021-03-24T16:46:45.000+01:00
diff --git a/pkg/cmd/issue/list/list.go b/pkg/cmd/issue/list/list.go
@@ -78,7 +78,8 @@ func NewCmdList(f *cmdutil.Factory, runF func(*ListOptions) error) *cobra.Comman
 	cmd.Flags().StringVarP(&opts.Author, "author", "A", "", "Filter by author")
 	cmd.Flags().StringVar(&opts.Mention, "mention", "", "Filter by mention")
 	cmd.Flags().StringVarP(&opts.Milestone, "milestone", "m", "", "Filter by milestone `number` or `title`")
-	cmd.Flags().StringVarP(&opts.Search, "search", "S", "", "Search issues with filter")
+	cmd.Flags().StringVarP(&opts.Search, "search", "S", "", "Search issues with `query`")
+
 	return cmd
 }
 
diff --git a/pkg/cmd/pr/list/http.go b/pkg/cmd/pr/list/http.go
@@ -24,7 +24,7 @@ const fragment = `fragment pr on PullRequest {
 }`
 
 func listPullRequests(httpClient *http.Client, repo ghrepo.Interface, filters prShared.FilterOptions, limit int) (*api.PullRequestAndTotalCount, error) {
-	if filters.Assignee != "" {
+	if filters.Assignee != "" || filters.Search != "" {
 		return searchPullRequests(httpClient, repo, filters, limit)
 	}
 
@@ -171,6 +171,7 @@ func searchPullRequests(httpClient *http.Client, repo ghrepo.Interface, filters
 	q := githubsearch.NewQuery()
 	q.SetType(githubsearch.PullRequest)
 	q.InRepository(ghrepo.FullName(repo))
+	q.AddQuery(filters.Search)
 	q.SortBy(githubsearch.CreatedAt, githubsearch.Desc)
 
 	switch filters.State {
diff --git a/pkg/cmd/pr/list/list.go b/pkg/cmd/pr/list/list.go
@@ -28,6 +28,7 @@ type ListOptions struct {
 	BaseBranch   string
 	Labels       []string
 	Assignee     string
+	Search       string
 }
 
 func NewCmdList(f *cmdutil.Factory, runF func(*ListOptions) error) *cobra.Command {
@@ -40,9 +41,8 @@ func NewCmdList(f *cmdutil.Factory, runF func(*ListOptions) error) *cobra.Comman
 		Use:   "list",
 		Short: "List and filter pull requests in this repository",
 		Example: heredoc.Doc(`
-			$ gh pr list --limit 999
-			$ gh pr list --state closed
-			$ gh pr list --label "priority 1" --label "bug"
+			$ gh pr list --label bug --label "priority 1"
+			$ gh pr list --search "status:success review:required"
 			$ gh pr list --web
     	`),
 		Args: cmdutil.NoArgsQuoteReminder,
@@ -67,6 +67,7 @@ func NewCmdList(f *cmdutil.Factory, runF func(*ListOptions) error) *cobra.Comman
 	cmd.Flags().StringVarP(&opts.BaseBranch, "base", "B", "", "Filter by base branch")
 	cmd.Flags().StringSliceVarP(&opts.Labels, "label", "l", nil, "Filter by labels")
 	cmd.Flags().StringVarP(&opts.Assignee, "assignee", "a", "", "Filter by assignee")
+	cmd.Flags().StringVarP(&opts.Search, "search", "S", "", "Search pull requests with `query`")
 
 	return cmd
 }
@@ -88,6 +89,7 @@ func listRun(opts *ListOptions) error {
 		Assignee:   opts.Assignee,
 		Labels:     opts.Labels,
 		BaseBranch: opts.BaseBranch,
+		Search:     opts.Search,
 	}
 
 	if opts.WebMode {

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,8 @@ func NewCmdList(f cmdutil.Factory, runF func(ListOptions) error) *cobra.Comman`
`78`	`78`	`cmd.Flags().StringVarP(&opts.Author, "author", "A", "", "Filter by author")`
`79`	`79`	`cmd.Flags().StringVar(&opts.Mention, "mention", "", "Filter by mention")`
`80`	`80`	cmd.Flags().StringVarP(&opts.Milestone, "milestone", "m", "", "Filter by milestone `number` or `title`")
`81`		`- cmd.Flags().StringVarP(&opts.Search, "search", "S", "", "Search issues with filter")`
	`81`	+ cmd.Flags().StringVarP(&opts.Search, "search", "S", "", "Search issues with `query`")
	`82`	`+`
`82`	`83`	`return cmd`
`83`	`84`	`}`
`84`	`85`