fix(release): discussion category with assets

keijun-kumagai · keijun-kumagai · commit 015b9f7fea68 · 2022-01-11T01:49:19.000+09:00
diff --git a/pkg/cmd/release/create/create.go b/pkg/cmd/release/create/create.go
@@ -418,7 +418,12 @@ func createRun(opts *CreateOptions) error {
 		}
 
 		if !opts.Draft {
-			rel, err := publishRelease(httpClient, newRelease.APIURL)
+			params := map[string]interface{}{}
+			params["draft"] = false
+			if opts.DiscussionCategory != "" {
+				params["discussion_category_name"] = opts.DiscussionCategory
+			}
+			rel, err := publishRelease(httpClient, newRelease.APIURL, params)
 			if err != nil {
 				return err
 			}
diff --git a/pkg/cmd/release/create/http.go b/pkg/cmd/release/create/http.go
@@ -134,8 +134,9 @@ func createRelease(httpClient *http.Client, repo ghrepo.Interface, params map[st
 	return &newRelease, err
 }
 
-func publishRelease(httpClient *http.Client, releaseURL string) (*shared.Release, error) {
-	req, err := http.NewRequest("PATCH", releaseURL, bytes.NewBufferString(`{"draft":false}`))
+func publishRelease(httpClient *http.Client, releaseURL string, params map[string]interface{}) (*shared.Release, error) {
+	bodyBytes, err := json.Marshal(params)
+	req, err := http.NewRequest("PATCH", releaseURL, bytes.NewBuffer(bodyBytes))
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -418,7 +418,12 @@ func createRun(opts *CreateOptions) error {`
`418`	`418`	`}`
`419`	`419`
`420`	`420`	`if !opts.Draft {`
`421`		`- rel, err := publishRelease(httpClient, newRelease.APIURL)`
	`421`	`+ params := map[string]interface{}{}`
	`422`	`+ params["draft"] = false`
	`423`	`+ if opts.DiscussionCategory != "" {`
	`424`	`+ params["discussion_category_name"] = opts.DiscussionCategory`
	`425`	`+ }`
	`426`	`+ rel, err := publishRelease(httpClient, newRelease.APIURL, params)`
`422`	`427`	`if err != nil {`
`423`	`428`	`return err`
`424`	`429`	`}`
Original file line number	Diff line number	Diff line change
`@@ -134,8 +134,9 @@ func createRelease(httpClient *http.Client, repo ghrepo.Interface, params map[st`
`134`	`134`	`return &newRelease, err`
`135`	`135`	`}`
`136`	`136`
`137`		`-func publishRelease(httpClient http.Client, releaseURL string) (shared.Release, error) {`
`138`		- req, err := http.NewRequest("PATCH", releaseURL, bytes.NewBufferString(`{"draft":false}`))
	`137`	`+func publishRelease(httpClient http.Client, releaseURL string, params map[string]interface{}) (shared.Release, error) {`
	`138`	`+ bodyBytes, err := json.Marshal(params)`
	`139`	`+ req, err := http.NewRequest("PATCH", releaseURL, bytes.NewBuffer(bodyBytes))`
`139`	`140`	`if err != nil {`
`140`	`141`	`return nil, err`
`141`	`142`	`}`