linter appeasement

vilmibm · vilmibm · commit 011c13413eba · 2021-02-05T14:00:25.000-08:00
diff --git a/pkg/cmd/actions/actions.go b/pkg/cmd/actions/actions.go
@@ -32,7 +32,7 @@ func NewCmdActions(f *cmdutil.Factory) *cobra.Command {
 
 func actionsRun(opts ActionsOptions) {
 	cs := opts.IO.ColorScheme()
-	fmt.Fprint(opts.IO.Out, fmt.Sprintf(heredoc.Doc(`
+	fmt.Fprint(opts.IO.Out, heredoc.Docf(`
 		Welcome to GitHub Actions on the command line.
 
 		%s
@@ -49,7 +49,7 @@ func actionsRun(opts ActionsOptions) {
 		%s
 		gh job view:   View details for a given job
 		gh job run:    Run a given job within a workflow
-	`),
+	`,
 		cs.Bold("Working with workflows"),
 		cs.Bold("Working with runs"),
 		cs.Bold("Working with jobs within runs")))
diff --git a/pkg/cmd/job/view/view.go b/pkg/cmd/job/view/view.go
@@ -115,6 +115,7 @@ func runView(opts *ViewOptions) error {
 			opts.IO.StopProgressIndicator()
 		}
 
+		// TODO if only one job in run, don't bother prompting just select it
 		jobID, err = promptForJob(*opts, client, repo, *run)
 		if err != nil {
 			// TODO error handle
@@ -146,7 +147,7 @@ func runView(opts *ViewOptions) error {
 			if n <= 0 {
 				break
 			}
-			fmt.Fprintf(out, string(buff[0:n]))
+			fmt.Fprint(out, string(buff[0:n]))
 			if err != nil {
 				break
 			}
diff --git a/pkg/cmd/run/list/list.go b/pkg/cmd/run/list/list.go
@@ -124,7 +124,7 @@ func listRun(opts *ListOptions) error {
 
 		if opts.PlainOutput {
 			elapsed := run.UpdatedAt.Sub(run.CreatedAt)
-			tp.AddField(fmt.Sprintf("%s", elapsed), nil, nil)
+			tp.AddField(elapsed.String(), nil, nil)
 		}
 
 		tp.AddField(fmt.Sprintf("%d", run.ID), nil, cs.Cyan)
diff --git a/pkg/cmd/run/view/view.go b/pkg/cmd/run/view/view.go
@@ -115,10 +115,7 @@ func runView(opts *ViewOptions) error {
 		if annotationErr != nil {
 			break
 		}
-
-		for _, a := range as {
-			annotations = append(annotations, a)
-		}
+		annotations = append(annotations, as...)
 	}
 
 	if annotationErr != nil {

Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,7 @@ func runView(opts *ViewOptions) error {`
`115`	`115`	`opts.IO.StopProgressIndicator()`
`116`	`116`	`}`
`117`	`117`
	`118`	`+ // TODO if only one job in run, don't bother prompting just select it`
`118`	`119`	`jobID, err = promptForJob(opts, client, repo, run)`
`119`	`120`	`if err != nil {`
`120`	`121`	`// TODO error handle`
`@@ -146,7 +147,7 @@ func runView(opts *ViewOptions) error {`
`146`	`147`	`if n <= 0 {`
`147`	`148`	`break`
`148`	`149`	`}`
`149`		`- fmt.Fprintf(out, string(buff[0:n]))`
	`150`	`+ fmt.Fprint(out, string(buff[0:n]))`
`150`	`151`	`if err != nil {`
`151`	`152`	`break`
`152`	`153`	`}`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ func listRun(opts *ListOptions) error {`
`124`	`124`
`125`	`125`	`if opts.PlainOutput {`
`126`	`126`	`elapsed := run.UpdatedAt.Sub(run.CreatedAt)`
`127`		`- tp.AddField(fmt.Sprintf("%s", elapsed), nil, nil)`
	`127`	`+ tp.AddField(elapsed.String(), nil, nil)`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`tp.AddField(fmt.Sprintf("%d", run.ID), nil, cs.Cyan)`
Original file line number	Diff line number	Diff line change
`@@ -115,10 +115,7 @@ func runView(opts *ViewOptions) error {`
`115`	`115`	`if annotationErr != nil {`
`116`	`116`	`break`
`117`	`117`	`}`
`118`		`-`
`119`		`- for _, a := range as {`
`120`		`- annotations = append(annotations, a)`
`121`		`- }`
	`118`	`+ annotations = append(annotations, as...)`
`122`	`119`	`}`
`123`	`120`
`124`	`121`	`if annotationErr != nil {`