- Submitted a ticket for my issue if one did not already exist.
- Used Github auto-closing keywords in the commit message.
- Added/updated tests for this change (for new code or code which already has tests).
- Verified that these changes build without errors on
- Android
- iOS
- Linux
- macOS
- Windows
- Verified that these changes pass automated tests (unit, browser, security tests) on
- iOS
- Linux
- macOS
- Windows
- Ran
git rebase master(if needed). - Ran
git rebase -ito squash commits (if needed). - Tagged reviewers and labelled the pull request as needed.
- Requested a security/privacy review as needed.
- Public documentation has been updated as necessary. For instance:
- https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
- https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- https://github.com/brave/brave-browser/wiki/Custom-Headers
- https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
- New files have MPL-2.0 license header.
- Request a security/privacy review as needed.
- Adequate test coverage exists to prevent regressions.
- The associated issue milestone is set to the smallest version that the changes has landed on.
- All relevant documentation has been updated.