Remove unused features (letsencrypt#3393)

Roland Bracewell Shoemaker · cpu · commit fc5c8f76b63b · 2018-01-25T08:55:05.000-05:00
This removes a number of unused features (i.e. they are never checked anywhere).
diff --git a/features/featureflag_string.go b/features/featureflag_string.go
diff --git a/features/features.go b/features/features.go
@@ -11,23 +11,14 @@ type FeatureFlag int
 
 const (
 	unused FeatureFlag = iota // unused is used for testing
-	AllowAccountDeactivation
-	AllowKeyRollover
-	ResubmitMissingSCTsOnly
 	UseAIAIssuerURL
 	AllowTLS02Challenges
-	GenerateOCSPEarly
 	// For new-authz requests, if there is no valid authz, but there is a pending
 	// authz, return that instead of creating a new one.
 	ReusePendingAuthz
 	CountCertificatesExact
-	RandomDirectoryEntry
 	IPv6First
-	DirectoryMeta
 	AllowRenewalFirstRL
-	RecheckCAA
-	UDPDNS
-	ROCACheck
 	// Allow issuance of wildcard domains for ACMEv2
 	WildcardDomains
 	// Enforce prevention of use of disabled challenge types
@@ -38,25 +29,16 @@ const (
 
 // List of features and their default value, protected by fMu
 var features = map[FeatureFlag]bool{
-	unused: false,
-	AllowAccountDeactivation: false,
-	AllowKeyRollover:         false,
-	ResubmitMissingSCTsOnly:  false,
-	UseAIAIssuerURL:          false,
-	AllowTLS02Challenges:     false,
-	GenerateOCSPEarly:        false,
-	ReusePendingAuthz:        false,
-	CountCertificatesExact:   false,
-	RandomDirectoryEntry:     false,
-	IPv6First:                false,
-	DirectoryMeta:            false,
-	AllowRenewalFirstRL:      false,
-	RecheckCAA:               false,
-	UDPDNS:                   false,
-	ROCACheck:                false,
-	WildcardDomains:          false,
-	EnforceChallengeDisable:  false,
-	TLSSNIRevalidation:       false,
+	unused:                  false,
+	UseAIAIssuerURL:         false,
+	AllowTLS02Challenges:    false,
+	ReusePendingAuthz:       false,
+	CountCertificatesExact:  false,
+	IPv6First:               false,
+	AllowRenewalFirstRL:     false,
+	WildcardDomains:         false,
+	EnforceChallengeDisable: false,
+	TLSSNIRevalidation:      false,
 }
 
 var fMu = new(sync.RWMutex)
diff --git a/sa/sa_test.go b/sa/sa_test.go
@@ -26,7 +26,6 @@ import (
 	"github.com/letsencrypt/boulder/core"
 	corepb "github.com/letsencrypt/boulder/core/proto"
 	berrors "github.com/letsencrypt/boulder/errors"
-	"github.com/letsencrypt/boulder/features"
 	blog "github.com/letsencrypt/boulder/log"
 	"github.com/letsencrypt/boulder/metrics"
 	"github.com/letsencrypt/boulder/revocation"
@@ -530,7 +529,6 @@ func TestAddCertificate(t *testing.T) {
 	test.Assert(t, certificateStatus2.OCSPLastUpdated.IsZero(), "OCSPLastUpdated should be nil")
 
 	// Test adding OCSP response with cert
-	_ = features.Set(map[string]bool{"GenerateOCSPEarly": true})
 	certDER3, err := ioutil.ReadFile("test-cert2.der")
 	test.AssertNotError(t, err, "Couldn't read example cert DER")
 	serial = "ffa0160630d618b2eb5c0510824b14274856"
diff --git a/test/config-next/ca.json b/test/config-next/ca.json
@@ -132,8 +132,7 @@
     "maxConcurrentRPCServerRequests": 100000,
     "features": {
         "WildcardDomains": true,
-        "AllowTLS02Challenges": true,
-        "GenerateOCSPEarly": true
+        "AllowTLS02Challenges": true
     }
   },
 
diff --git a/test/config-next/ra.json b/test/config-next/ra.json
@@ -44,10 +44,8 @@
     "features": {
       "WildcardDomains": true,
       "TLSSNIRevalidation": true,
-      "AllowKeyRollover": true,
       "AllowTLS02Challenges": true,
       "CountCertificatesExact": true,
-      "RecheckCAA": true,
       "ReusePendingAuthz": true,
       "EnforceChallengeDisable": true
     }
diff --git a/test/config-next/sa.json b/test/config-next/sa.json
@@ -27,7 +27,6 @@
     },
     "features": {
       "WildcardDomains": true,
-      "AllowAccountDeactivation": true,
       "AllowRenewalFirstRL": true,
       "EnforceChallengeDisable": true
     }
diff --git a/test/config-next/wfe.json b/test/config-next/wfe.json
@@ -29,11 +29,7 @@
       "timeout": "15s"
     },
     "features": {
-      "AllowAccountDeactivation": true,
-      "AllowKeyRollover": true,
-      "UseAIAIssuerURL": true,
-      "RandomDirectoryEntry": true,
-      "DirectoryMeta": true
+      "UseAIAIssuerURL": true
     }
   },
 
diff --git a/test/config/ca.json b/test/config/ca.json
@@ -130,7 +130,6 @@
     },
     "maxConcurrentRPCServerRequests": 100000,
     "features": {
-        "GenerateOCSPEarly": true
     }
   },
 
diff --git a/test/config/ra.json b/test/config/ra.json
@@ -41,9 +41,7 @@
       ]
     },
     "features": {
-      "AllowKeyRollover": true,
       "CountCertificatesExact": true,
-      "RecheckCAA": true,
       "ReusePendingAuthz": false,
       "EnforceChallengeDisable": true
     }
diff --git a/test/config/sa.json b/test/config/sa.json
@@ -25,7 +25,6 @@
       ]
     },
     "features": {
-      "AllowAccountDeactivation": true,
       "EnforceChallengeDisable": true
     }
   },
diff --git a/test/config/wfe.json b/test/config/wfe.json
@@ -30,10 +30,6 @@
       "timeout": "15s"
     },
     "features": {
-      "AllowAccountDeactivation": true,
-      "AllowKeyRollover": true,
-      "RandomDirectoryEntry": true,
-      "DirectoryMeta": true
     }
   },
 
diff --git a/test/integration-test.py b/test/integration-test.py
@@ -227,9 +227,6 @@ def test_ct_submission():
     if (int(submissions_a) < expected_a_submissions or
         int(submissions_a) > 2 * expected_a_submissions):
         raise Exception("Expected %d CT submissions to boulder:4500, found %s" % (expected_a_submissions, submissions_a))
-    # Only test when ResubmitMissingSCTsOnly is enabled
-    if not default_config_dir.startswith("test/config-next"):
-        return
     for _ in range(0, 10):
         submissions_a = urllib2.urlopen(url_a).read()
         submissions_b = urllib2.urlopen(url_b).read()

Original file line number	Diff line number	Diff line change
`@@ -132,8 +132,7 @@`
`132`	`132`	`"maxConcurrentRPCServerRequests": 100000,`
`133`	`133`	`"features": {`
`134`	`134`	`"WildcardDomains": true,`
`135`		`- "AllowTLS02Challenges": true,`
`136`		`- "GenerateOCSPEarly": true`
	`135`	`+ "AllowTLS02Challenges": true`
`137`	`136`	`}`
`138`	`137`	`},`
`139`	`138`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@`
`27`	`27`	`},`
`28`	`28`	`"features": {`
`29`	`29`	`"WildcardDomains": true,`
`30`		`- "AllowAccountDeactivation": true,`
`31`	`30`	`"AllowRenewalFirstRL": true,`
`32`	`31`	`"EnforceChallengeDisable": true`
`33`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,6 @@`
`130`	`130`	`},`
`131`	`131`	`"maxConcurrentRPCServerRequests": 100000,`
`132`	`132`	`"features": {`
`133`		`- "GenerateOCSPEarly": true`
`134`	`133`	`}`
`135`	`134`	`},`
`136`	`135`
Original file line number	Diff line number	Diff line change
`@@ -41,9 +41,7 @@`
`41`	`41`	`]`
`42`	`42`	`},`
`43`	`43`	`"features": {`
`44`		`- "AllowKeyRollover": true,`
`45`	`44`	`"CountCertificatesExact": true,`
`46`		`- "RecheckCAA": true,`
`47`	`45`	`"ReusePendingAuthz": false,`
`48`	`46`	`"EnforceChallengeDisable": true`
`49`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@`
`25`	`25`	`]`
`26`	`26`	`},`
`27`	`27`	`"features": {`
`28`		`- "AllowAccountDeactivation": true,`
`29`	`28`	`"EnforceChallengeDisable": true`
`30`	`29`	`}`
`31`	`30`	`},`