Remove unused code in SA. (letsencrypt#4710)

jsha · web-flow · commit e92c5c66ea89 · 2020-03-18T13:17:56.000-07:00
Spotted by staticcheck.
diff --git a/sa/authz.go b/sa/authz.go
diff --git a/sa/model.go b/sa/model.go
@@ -183,13 +183,6 @@ type challModel struct {
 	LockCol int64
 }
 
-// getChallengesQuery fetches exactly the fields in challModel from the
-// challenges table.
-const getChallengesQuery = `
-	SELECT id, authorizationID, type, status, error, token,
-		keyAuthorization, validationRecord
-	FROM challenges WHERE authorizationID = :authID ORDER BY id ASC`
-
 // newReg creates a reg model object from a core.Registration
 func registrationToModel(r *core.Registration) (*regModel, error) {
 	key, err := json.Marshal(r.Key)
@@ -253,37 +246,6 @@ func modelToRegistration(reg *regModel) (core.Registration, error) {
 	return r, nil
 }
 
-func challengeToModel(c *core.Challenge, authID string) (*challModel, error) {
-	cm := challModel{
-		AuthorizationID:  authID,
-		Type:             c.Type,
-		Status:           c.Status,
-		Token:            c.Token,
-		KeyAuthorization: c.ProvidedKeyAuthorization,
-	}
-	if c.Error != nil {
-		errJSON, err := json.Marshal(c.Error)
-		if err != nil {
-			return nil, err
-		}
-		if len(errJSON) > mediumBlobSize {
-			return nil, fmt.Errorf("Error object is too large to store in the database")
-		}
-		cm.Error = errJSON
-	}
-	if len(c.ValidationRecord) > 0 {
-		vrJSON, err := json.Marshal(c.ValidationRecord)
-		if err != nil {
-			return nil, err
-		}
-		if len(vrJSON) > mediumBlobSize {
-			return nil, fmt.Errorf("Validation Record object is too large to store in the database")
-		}
-		cm.ValidationRecord = vrJSON
-	}
-	return &cm, nil
-}
-
 func modelToChallenge(cm *challModel) (core.Challenge, error) {
 	c := core.Challenge{
 		Type:                     cm.Type,
diff --git a/sa/sa.go b/sa/sa.go
@@ -14,7 +14,6 @@ import (
 
 	"github.com/jmhodges/clock"
 	"github.com/prometheus/client_golang/prometheus"
-	"gopkg.in/go-gorp/gorp.v2"
 	jose "gopkg.in/square/go-jose.v2"
 
 	"github.com/letsencrypt/boulder/core"
@@ -53,12 +52,6 @@ type SQLStorageAuthority struct {
 	rateLimitWriteErrors prometheus.Counter
 }
 
-func digest256(data []byte) []byte {
-	d := sha256.New()
-	_, _ = d.Write(data) // Never returns an error
-	return d.Sum(nil)
-}
-
 // orderFQDNSet contains the SHA256 hash of the lowercased, comma joined names
 // from a new-order request, along with the corresponding orderID, the
 // registration ID, and the order expiry. This is used to find
@@ -71,16 +64,6 @@ type orderFQDNSet struct {
 	Expires        time.Time
 }
 
-const (
-	authorizationTable        = "authz"
-	pendingAuthorizationTable = "pendingAuthorizations"
-)
-
-var authorizationTables = []string{
-	authorizationTable,
-	pendingAuthorizationTable,
-}
-
 // NewSQLStorageAuthority provides persistence using a SQL backend for
 // Boulder. It will modify the given gorp.DbMap by adding relevant tables.
 func NewSQLStorageAuthority(
@@ -111,28 +94,6 @@ func NewSQLStorageAuthority(
 	return ssa, nil
 }
 
-func statusIsPending(status core.AcmeStatus) bool {
-	return status == core.StatusPending || status == core.StatusProcessing || status == core.StatusUnknown
-}
-
-func existingPending(dbMap db.OneSelector, id string) bool {
-	var count int64
-	_ = dbMap.SelectOne(&count, "SELECT count(*) FROM pendingAuthorizations WHERE id = :id", map[string]interface{}{"id": id})
-	return count > 0
-}
-
-func existingFinal(dbMap db.OneSelector, id string) bool {
-	var count int64
-	_ = dbMap.SelectOne(&count, "SELECT count(*) FROM authz WHERE id = :id", map[string]interface{}{"id": id})
-	return count > 0
-}
-
-func existingRegistration(tx *gorp.Transaction, id int64) bool {
-	var count int64
-	_ = tx.SelectOne(&count, "SELECT count(*) FROM registrations WHERE id = :id", map[string]interface{}{"id": id})
-	return count > 0
-}
-
 // GetRegistration obtains a Registration by ID
 func (ssa *SQLStorageAuthority) GetRegistration(ctx context.Context, id int64) (core.Registration, error) {
 	const query = "WHERE id = ?"
