startservers: Add some dependencies. (letsencrypt#5131)

jsha · web-flow · commit d5c22eae83a6 · 2020-10-16T14:41:08.000-07:00
bad-key-revoker was listed with no dependencies, and boulder-va did not
list its remoteva backends as dependencies. This led to some spurious
error messages in log output.
diff --git a/test/startservers.py b/test/startservers.py
@@ -18,10 +18,6 @@
         53, None,
         ('./bin/sd-test-srv', '--listen', ':53'),
         None),
-    Service('bad-key-revoker',
-        8020, None,
-        ('./bin/bad-key-revoker', '--config', os.path.join(config_dir, 'bad-key-revoker.json')),
-        None),
     Service('boulder-remoteva-a',
         8011, 'va1.boulder:9097',
         ('./bin/boulder-remoteva', '--config', os.path.join(config_dir, 'va-remote-a.json')),
@@ -61,11 +57,11 @@
     Service('boulder-va-1',
         8004, 'va1.boulder:9092',
         ('./bin/boulder-va', '--config', os.path.join(config_dir, 'va.json'), '--addr', 'va1.boulder:9092', '--debug-addr', ':8004'),
-        ('sd-test-srv',)),
+        ('sd-test-srv', 'boulder-remoteva-a', 'boulder-remoteva-b')),
     Service('boulder-va-2',
         8104, 'va2.boulder:9092',
         ('./bin/boulder-va', '--config', os.path.join(config_dir, 'va.json'), '--addr', 'va2.boulder:9092', '--debug-addr', ':8104'),
-        ('sd-test-srv',)),
+        ('sd-test-srv', 'boulder-remoteva-a', 'boulder-remoteva-b')),
     Service('boulder-ca-a',
         8001, 'ca1.boulder:9093',
         ('./bin/boulder-ca', '--config', os.path.join(config_dir, 'ca-a.json'), '--ca-addr', 'ca1.boulder:9093', '--ocsp-addr', 'ca1.boulder:9096', '--debug-addr', ':8001'),
@@ -94,6 +90,10 @@
         8102, 'ra2.boulder:9094',
         ('./bin/boulder-ra', '--config', os.path.join(config_dir, 'ra.json'), '--addr', 'ra2.boulder:9094', '--debug-addr', ':8102'),
         ('sd-test-srv', 'boulder-sa-1', 'boulder-sa-2', 'boulder-ca-a', 'boulder-ca-b', 'boulder-va-1', 'boulder-va-2', 'akamai-purger', 'boulder-publisher-1', 'boulder-publisher-2')),
+    Service('bad-key-revoker',
+        8020, None,
+        ('./bin/bad-key-revoker', '--config', os.path.join(config_dir, 'bad-key-revoker.json')),
+        ('sd-test-srv', 'boulder-ra-1', 'boulder-ra-2', 'mail-test-srv')),
     Service('nonce-service-taro',
         8111, 'nonce1.boulder:9101',
         ('./bin/nonce-service', '--config', os.path.join(config_dir, 'nonce.json'), '--addr', 'nonce1.boulder:9101', '--debug-addr', ':8111', '--prefix', 'taro'),
