Add error checking in load-generator and ocsp_forever (letsencrypt#4765)

jsha · web-flow · commit 84a51ecce079 · 2020-04-08T17:26:42.000-07:00
Found by golangci-lint's errcheck invocation.
diff --git a/test/load-generator/boulder-calls.go b/test/load-generator/boulder-calls.go
@@ -337,7 +337,7 @@ func completeAuthorization(authz *core.Authorization, s *State, ctx *context) er
 
 	// Poll the authorization waiting for the challenge response to be recorded in
 	// a change of state. The polling may sleep and retry a few times if required
-	pollAuthorization(authz, s, ctx)
+	err = pollAuthorization(authz, s, ctx)
 	if err != nil {
 		return err
 	}
diff --git a/test/ocsp/ocsp_forever/main.go b/test/ocsp/ocsp_forever/main.go
@@ -79,7 +79,12 @@ func main() {
 		log.Fatal(err)
 	}
 	http.Handle("/metrics", promhttp.Handler())
-	go http.ListenAndServe(*listenAddress, nil)
+	go func() {
+		err = http.ListenAndServe(*listenAddress, nil)
+		if err != nil && err != http.ErrServerClosed {
+			log.Fatal(err)
+		}
+	}()
 	for {
 		for _, pattern := range flag.Args() {
 			// Note: re-glob this pattern on each run, in case new certificates have

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ func completeAuthorization(authz core.Authorization, s State, ctx *context) er`
`337`	`337`
`338`	`338`	`// Poll the authorization waiting for the challenge response to be recorded in`
`339`	`339`	`// a change of state. The polling may sleep and retry a few times if required`
`340`		`- pollAuthorization(authz, s, ctx)`
	`340`	`+ err = pollAuthorization(authz, s, ctx)`
`341`	`341`	`if err != nil {`
`342`	`342`	`return err`
`343`	`343`	`}`