Lower logDNSError to info level. (letsencrypt#5701)

jsha · web-flow · commit 4205400a98c8 · 2021-10-12T10:44:54.000-06:00
These log lines are sometimes useful for debugging, but are a normal
part of operation, not an error: Unbound will allow a response to
timeout if the remote server is too slow.
diff --git a/bdns/dns.go b/bdns/dns.go
@@ -561,7 +561,7 @@ func logDNSError(
 			}
 		}
 
-		logger.Errf(
+		logger.Infof(
 			"logDNSError ID mismatch chosenServer=[%s] hostname=[%s] respHostname=[%s] queryType=[%s] err=[%s] msg=[%s] resp=[%s]",
 			chosenServer,
 			hostname,
@@ -572,7 +572,7 @@ func logDNSError(
 			encodedResp)
 	} else {
 		// Otherwise log a general DNS error
-		logger.Errf("logDNSError chosenServer=[%s] hostname=[%s] queryType=[%s] err=[%s]",
+		logger.Infof("logDNSError chosenServer=[%s] hostname=[%s] queryType=[%s] err=[%s]",
 			chosenServer,
 			hostname,
 			queryType,
diff --git a/va/http_test.go b/va/http_test.go
@@ -343,7 +343,7 @@ func TestHTTPValidationDNSIdMismatchError(t *testing.T) {
 			strings.Join(mockLog.GetAllMatching(`.*`), "\n"))
 	}
 	expectedRegex := regexp.MustCompile(
-		`ERR: \[AUDIT\] logDNSError ID mismatch ` +
+		`INFO: logDNSError ID mismatch ` +
 			`chosenServer=\[mock.server\] ` +
 			`hostname=\[id\.mismatch\] ` +
 			`respHostname=\[id\.mismatch\.\] ` +

Original file line number	Diff line number	Diff line change
`@@ -343,7 +343,7 @@ func TestHTTPValidationDNSIdMismatchError(t *testing.T) {`
`343`	`343`	strings.Join(mockLog.GetAllMatching(`.*`), "\n"))
`344`	`344`	`}`
`345`	`345`	`expectedRegex := regexp.MustCompile(`
`346`		- `ERR: \[AUDIT\] logDNSError ID mismatch ` +
	`346`	+ `INFO: logDNSError ID mismatch ` +
`347`	`347`	`chosenServer=\[mock.server\] ` +
`348`	`348`	`hostname=\[id\.mismatch\] ` +
`349`	`349`	`respHostname=\[id\.mismatch\.\] ` +