Merge pull request letsencrypt#2729 from letsencrypt/remove-old-err-checks

cpu · web-flow · commit 406f5768ff12 · 2017-05-04T12:44:30.000-04:00
Remove core.XXXError type checks
diff --git a/cmd/orphan-finder/main.go b/cmd/orphan-finder/main.go
@@ -67,9 +67,7 @@ func checkDER(sai certificateStorage, der []byte) error {
 	if err == nil {
 		return errAlreadyExists
 	}
-	// TODO(#2600): Remove core.NotFoundError check once boulder/errors
-	// code is deployed
-	if _, ok := err.(core.NotFoundError); ok || berrors.Is(err, berrors.NotFound) {
+	if berrors.Is(err, berrors.NotFound) {
 		return nil
 	}
 	return fmt.Errorf("Existing certificate lookup failed: %s", err)
diff --git a/wfe/wfe.go b/wfe/wfe.go
@@ -477,9 +477,7 @@ func (wfe *WebFrontEndImpl) verifyPOST(ctx context.Context, logEvent *requestEve
 	// Special case: If no registration was found, but regCheck is false, use an
 	// empty registration and the submitted key. The caller is expected to do some
 	// validation on the returned key.
-	// TODO(#2600): Remove core.NoSuchRegistrationError check once boulder/errors
-	// code is deployed
-	if _, ok := err.(core.NoSuchRegistrationError); (ok || berrors.Is(err, berrors.NotFound)) && !regCheck {
+	if berrors.Is(err, berrors.NotFound) && !regCheck {
 		// When looking up keys from the registrations DB, we can be confident they
 		// are "good". But when we are verifying against any submitted key, we want
 		// to check its quality before doing the verify.
@@ -493,9 +491,7 @@ func (wfe *WebFrontEndImpl) verifyPOST(ctx context.Context, logEvent *requestEve
 		// For all other errors, or if regCheck is true, return error immediately.
 		wfe.stats.Inc("Errors.UnableToGetRegistrationByKey", 1)
 		logEvent.AddError("unable to fetch registration by the given JWK: %s", err)
-		// TODO(#2600): Remove core.NoSuchRegistrationError check once boulder/errors
-		// code is deployed
-		if _, ok := err.(core.NoSuchRegistrationError); ok || berrors.Is(err, berrors.NotFound) {
+		if berrors.Is(err, berrors.NotFound) {
 			return nil, nil, reg, probs.Unauthorized(unknownKey)
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,7 @@ func checkDER(sai certificateStorage, der []byte) error {`
`67`	`67`	`if err == nil {`
`68`	`68`	`return errAlreadyExists`
`69`	`69`	`}`
`70`		`- // TODO(#2600): Remove core.NotFoundError check once boulder/errors`
`71`		`- // code is deployed`
`72`		`- if _, ok := err.(core.NotFoundError); ok \|\| berrors.Is(err, berrors.NotFound) {`
	`70`	`+ if berrors.Is(err, berrors.NotFound) {`
`73`	`71`	`return nil`
`74`	`72`	`}`
`75`	`73`	`return fmt.Errorf("Existing certificate lookup failed: %s", err)`