Shorten final certificate issuance log line. (letsencrypt#4861)

jsha · web-flow · commit 0fcfbc3e165a · 2020-06-10T16:19:32.000-07:00
Previously, we logged both the precertificate and the final certificate
when the final certificate was signed. However, we already log the
precertificate body at precertificate issuance time, and we can conect
the two log lines by serial, so this was making the final certificate
log line unnecessarily long.
diff --git a/ca/ca.go b/ca/ca.go
@@ -605,7 +605,7 @@ func (ca *CertificateAuthorityImpl) IssueCertificateForPrecertificate(ctx contex
 		return emptyCert, err
 	}
 	certDER := block.Bytes
-	ca.log.AuditInfof("Signing success: serial=[%s] names=[%s] precertificate=[%s] certificate=[%s]",
+	ca.log.AuditInfof("Signing success: serial=[%s] names=[%s] certificate=[%s]",
 		serialHex, strings.Join(precert.DNSNames, ", "), hex.EncodeToString(req.DER),
 		hex.EncodeToString(certDER))
 	return ca.storeCertificate(ctx, *req.RegistrationID, *req.OrderID, precert.SerialNumber, certDER)

Original file line number	Diff line number	Diff line change
`@@ -605,7 +605,7 @@ func (ca *CertificateAuthorityImpl) IssueCertificateForPrecertificate(ctx contex`
`605`	`605`	`return emptyCert, err`
`606`	`606`	`}`
`607`	`607`	`certDER := block.Bytes`
`608`		`- ca.log.AuditInfof("Signing success: serial=[%s] names=[%s] precertificate=[%s] certificate=[%s]",`
	`608`	`+ ca.log.AuditInfof("Signing success: serial=[%s] names=[%s] certificate=[%s]",`
`609`	`609`	`serialHex, strings.Join(precert.DNSNames, ", "), hex.EncodeToString(req.DER),`
`610`	`610`	`hex.EncodeToString(certDER))`
`611`	`611`	`return ca.storeCertificate(ctx, req.RegistrationID, req.OrderID, precert.SerialNumber, certDER)`