test: Plug memory leaks and stack-use-after-scope

MarcoFalke · MarcoFalke · commit fadb39ca6237 · 2018-02-22T14:53:14.000-05:00
diff --git a/src/bench/coin_selection.cpp b/src/bench/coin_selection.cpp
@@ -37,11 +37,6 @@ static void CoinSelection(benchmark::State& state)
     LOCK(wallet.cs_wallet);
 
     while (state.KeepRunning()) {
-        // Empty wallet.
-        for (COutput output : vCoins)
-            delete output.tx;
-        vCoins.clear();
-
         // Add coins.
         for (int i = 0; i < 1000; i++)
             addCoin(1000 * COIN, wallet, vCoins);
@@ -53,6 +48,12 @@ static void CoinSelection(benchmark::State& state)
         assert(success);
         assert(nValueRet == 1003 * COIN);
         assert(setCoinsRet.size() == 2);
+
+        // Empty wallet.
+        for (COutput& output : vCoins) {
+            delete output.tx;
+        }
+        vCoins.clear();
     }
 }
 
diff --git a/src/test/checkqueue_tests.cpp b/src/test/checkqueue_tests.cpp
@@ -406,11 +406,11 @@ BOOST_AUTO_TEST_CASE(test_CheckQueueControl_Locks)
         boost::thread_group tg;
         std::mutex m;
         std::condition_variable cv;
+        bool has_lock{false};
+        bool has_tried{false};
+        bool done{false};
+        bool done_ack{false};
         {
-            bool has_lock {false};
-            bool has_tried {false};
-            bool done {false};
-            bool done_ack {false};
             std::unique_lock<std::mutex> l(m);
             tg.create_thread([&]{
                     CCheckQueueControl<FakeCheck> control(queue.get());
diff --git a/src/test/test_bitcoin.cpp b/src/test/test_bitcoin.cpp
@@ -28,6 +28,9 @@ void CConnmanTest::AddNode(CNode& node)
 void CConnmanTest::ClearNodes()
 {
     LOCK(g_connman->cs_vNodes);
+    for (CNode* node : g_connman->vNodes) {
+        delete node;
+    }
     g_connman->vNodes.clear();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,9 @@ void CConnmanTest::AddNode(CNode& node)`
`28`	`28`	`void CConnmanTest::ClearNodes()`
`29`	`29`	`{`
`30`	`30`	`LOCK(g_connman->cs_vNodes);`
	`31`	`+ for (CNode* node : g_connman->vNodes) {`
	`32`	`+ delete node;`
	`33`	`+ }`
`31`	`34`	`g_connman->vNodes.clear();`
`32`	`35`	`}`
`33`	`36`