fuzz: Style fixups

MarcoFalke · MarcoFalke · commit fa2b95f86154 · 2021-03-23T10:58:32.000+01:00
diff --git a/src/test/fuzz/process_message.cpp b/src/test/fuzz/process_message.cpp
@@ -68,8 +68,8 @@ void fuzz_target(FuzzBufferType buffer, const std::string& LIMIT_TO_MESSAGE_TYPE
 {
     FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
 
-    ConnmanTestMsg& connman = *(ConnmanTestMsg*)g_setup->m_node.connman.get();
-    TestChainState& chainstate = *(TestChainState*)&g_setup->m_node.chainman->ActiveChainstate();
+    ConnmanTestMsg& connman = *static_cast<ConnmanTestMsg*>(g_setup->m_node.connman.get());
+    TestChainState& chainstate = *static_cast<TestChainState*>(&g_setup->m_node.chainman->ActiveChainstate());
     SetMockTime(1610000000); // any time to successfully reset ibd
     chainstate.ResetIbd();
 
diff --git a/src/test/fuzz/process_messages.cpp b/src/test/fuzz/process_messages.cpp
@@ -35,8 +35,8 @@ FUZZ_TARGET_INIT(process_messages, initialize_process_messages)
 {
     FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
 
-    ConnmanTestMsg& connman = *(ConnmanTestMsg*)g_setup->m_node.connman.get();
-    TestChainState& chainstate = *(TestChainState*)&g_setup->m_node.chainman->ActiveChainstate();
+    ConnmanTestMsg& connman = *static_cast<ConnmanTestMsg*>(g_setup->m_node.connman.get());
+    TestChainState& chainstate = *static_cast<TestChainState*>(&g_setup->m_node.chainman->ActiveChainstate());
     SetMockTime(1610000000); // any time to successfully reset ibd
     chainstate.ResetIbd();
 
diff --git a/src/test/fuzz/tx_pool.cpp b/src/test/fuzz/tx_pool.cpp
@@ -96,14 +96,13 @@ FUZZ_TARGET_INIT(tx_pool_standard, initialize_tx_pool)
     constexpr CAmount SUPPLY_TOTAL{COINBASE_MATURITY * 50 * COIN};
 
     CTxMemPool tx_pool_{/* estimator */ nullptr, /* check_ratio */ 1};
-    MockedTxPool& tx_pool = *(MockedTxPool*)&tx_pool_;
+    MockedTxPool& tx_pool = *static_cast<MockedTxPool*>(&tx_pool_);
 
     // Helper to query an amount
     const CCoinsViewMemPool amount_view{WITH_LOCK(::cs_main, return &chainstate.CoinsTip()), tx_pool};
     const auto GetAmount = [&](const COutPoint& outpoint) {
         Coin c;
-        amount_view.GetCoin(outpoint, c);
-        Assert(!c.IsSpent());
+        Assert(amount_view.GetCoin(outpoint, c));
         return c.out.nValue;
     };
 

Original file line number	Diff line number	Diff line change
`@@ -68,8 +68,8 @@ void fuzz_target(FuzzBufferType buffer, const std::string& LIMIT_TO_MESSAGE_TYPE`
`68`	`68`	`{`
`69`	`69`	`FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());`
`70`	`70`
`71`		`- ConnmanTestMsg& connman = (ConnmanTestMsg)g_setup->m_node.connman.get();`
`72`		`- TestChainState& chainstate = (TestChainState)&g_setup->m_node.chainman->ActiveChainstate();`
	`71`	`+ ConnmanTestMsg& connman = static_cast<ConnmanTestMsg>(g_setup->m_node.connman.get());`
	`72`	`+ TestChainState& chainstate = static_cast<TestChainState>(&g_setup->m_node.chainman->ActiveChainstate());`
`73`	`73`	`SetMockTime(1610000000); // any time to successfully reset ibd`
`74`	`74`	`chainstate.ResetIbd();`
`75`	`75`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,8 @@ FUZZ_TARGET_INIT(process_messages, initialize_process_messages)`
`35`	`35`	`{`
`36`	`36`	`FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());`
`37`	`37`
`38`		`- ConnmanTestMsg& connman = (ConnmanTestMsg)g_setup->m_node.connman.get();`
`39`		`- TestChainState& chainstate = (TestChainState)&g_setup->m_node.chainman->ActiveChainstate();`
	`38`	`+ ConnmanTestMsg& connman = static_cast<ConnmanTestMsg>(g_setup->m_node.connman.get());`
	`39`	`+ TestChainState& chainstate = static_cast<TestChainState>(&g_setup->m_node.chainman->ActiveChainstate());`
`40`	`40`	`SetMockTime(1610000000); // any time to successfully reset ibd`
`41`	`41`	`chainstate.ResetIbd();`
`42`	`42`