[addrman] Remove unused test_before_evict argument from Good()

jnewbery · jnewbery · commit f036dfbb692c · 2021-07-20T16:17:51.000+01:00
This has never been used in the public interface method since it was introduced in bitcoin#9037.
diff --git a/src/addrman.h b/src/addrman.h
@@ -536,12 +536,12 @@ class CAddrMan
     }
 
     //! Mark an entry as accessible.
-    void Good(const CService &addr, bool test_before_evict = true, int64_t nTime = GetAdjustedTime())
+    void Good(const CService &addr, int64_t nTime = GetAdjustedTime())
         EXCLUSIVE_LOCKS_REQUIRED(!cs)
     {
         LOCK(cs);
         Check();
-        Good_(addr, test_before_evict, nTime);
+        Good_(addr, /* test_before_evict */ true, nTime);
         Check();
     }
 
diff --git a/src/test/addrman_tests.cpp b/src/test/addrman_tests.cpp
@@ -76,7 +76,7 @@ class CAddrManTest : public CAddrMan
     {
          int64_t nLastSuccess = 1;
          // Set last good connection in the deep past.
-         Good(addr, true, nLastSuccess);
+         Good(addr, nLastSuccess);
 
          bool count_failure = false;
          int64_t nLastTry = GetAdjustedTime()-61;
diff --git a/src/test/fuzz/addrman.cpp b/src/test/fuzz/addrman.cpp
@@ -80,7 +80,7 @@ FUZZ_TARGET_INIT(addrman, initialize_addrman)
             [&] {
                 const std::optional<CService> opt_service = ConsumeDeserializable<CService>(fuzzed_data_provider);
                 if (opt_service) {
-                    addr_man.Good(*opt_service, fuzzed_data_provider.ConsumeBool(), ConsumeTime(fuzzed_data_provider));
+                    addr_man.Good(*opt_service, ConsumeTime(fuzzed_data_provider));
                 }
             },
             [&] {

Original file line number	Diff line number	Diff line change
`@@ -536,12 +536,12 @@ class CAddrMan`
`536`	`536`	`}`
`537`	`537`
`538`	`538`	`//! Mark an entry as accessible.`
`539`		`- void Good(const CService &addr, bool test_before_evict = true, int64_t nTime = GetAdjustedTime())`
	`539`	`+ void Good(const CService &addr, int64_t nTime = GetAdjustedTime())`
`540`	`540`	`EXCLUSIVE_LOCKS_REQUIRED(!cs)`
`541`	`541`	`{`
`542`	`542`	`LOCK(cs);`
`543`	`543`	`Check();`
`544`		`- Good_(addr, test_before_evict, nTime);`
	`544`	`+ Good_(addr, /* test_before_evict */ true, nTime);`
`545`	`545`	`Check();`
`546`	`546`	`}`
`547`	`547`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ class CAddrManTest : public CAddrMan`
`76`	`76`	`{`
`77`	`77`	`int64_t nLastSuccess = 1;`
`78`	`78`	`// Set last good connection in the deep past.`
`79`		`- Good(addr, true, nLastSuccess);`
	`79`	`+ Good(addr, nLastSuccess);`
`80`	`80`
`81`	`81`	`bool count_failure = false;`
`82`	`82`	`int64_t nLastTry = GetAdjustedTime()-61;`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ FUZZ_TARGET_INIT(addrman, initialize_addrman)`
`80`	`80`	`[&] {`
`81`	`81`	`const std::optional<CService> opt_service = ConsumeDeserializable<CService>(fuzzed_data_provider);`
`82`	`82`	`if (opt_service) {`
`83`		`- addr_man.Good(*opt_service, fuzzed_data_provider.ConsumeBool(), ConsumeTime(fuzzed_data_provider));`
	`83`	`+ addr_man.Good(*opt_service, ConsumeTime(fuzzed_data_provider));`
`84`	`84`	`}`
`85`	`85`	`},`
`86`	`86`	`[&] {`