speed up of tx_validationcache_tests by reusing of CTransaction.

lucash-dev · lucash-dev · commit ebebedce2094 · 2018-06-06T06:50:25.000-07:00
The code was converting CMutableTransaction to CTransaction multiple times, which implies recalculating the hash multiple times. This commit fixes this by reusing a single CTransaction.
diff --git a/src/test/txvalidationcache_tests.cpp b/src/test/txvalidationcache_tests.cpp
@@ -102,7 +102,7 @@ BOOST_FIXTURE_TEST_CASE(tx_mempool_block_doublespend, TestChain100Setup)
 // should fail.
 // Capture this interaction with the upgraded_nop argument: set it when evaluating
 // any script flag that is implemented as an upgraded NOP code.
-static void ValidateCheckInputsForAllFlags(CMutableTransaction &tx, uint32_t failing_flags, bool add_to_cache)
+static void ValidateCheckInputsForAllFlags(const CTransaction &tx, uint32_t failing_flags, bool add_to_cache)
 {
     PrecomputedTransactionData txdata(tx);
     // If we add many more flags, this loop can get too expensive, but we can

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ BOOST_FIXTURE_TEST_CASE(tx_mempool_block_doublespend, TestChain100Setup)`
`102`	`102`	`// should fail.`
`103`	`103`	`// Capture this interaction with the upgraded_nop argument: set it when evaluating`
`104`	`104`	`// any script flag that is implemented as an upgraded NOP code.`
`105`		`-static void ValidateCheckInputsForAllFlags(CMutableTransaction &tx, uint32_t failing_flags, bool add_to_cache)`
	`105`	`+static void ValidateCheckInputsForAllFlags(const CTransaction &tx, uint32_t failing_flags, bool add_to_cache)`
`106`	`106`	`{`
`107`	`107`	`PrecomputedTransactionData txdata(tx);`
`108`	`108`	`// If we add many more flags, this loop can get too expensive, but we can`