net: update NET_UNROUTABLE to not_publicly_routable in GetNetworkName()

jonatack · jonatack · commit b45eae4d5332 · 2021-02-02T00:00:39.000+01:00
diff --git a/src/netbase.cpp b/src/netbase.cpp
@@ -55,7 +55,7 @@ enum Network ParseNetwork(const std::string& net_in) {
 std::string GetNetworkName(enum Network net)
 {
     switch (net) {
-    case NET_UNROUTABLE: return "unroutable";
+    case NET_UNROUTABLE: return "not_publicly_routable";
     case NET_IPV4: return "ipv4";
     case NET_IPV6: return "ipv6";
     case NET_ONION: return "onion";
diff --git a/test/functional/feature_proxy.py b/test/functional/feature_proxy.py
@@ -44,8 +44,8 @@
 
 RANGE_BEGIN = PORT_MIN + 2 * PORT_RANGE  # Start after p2p and rpc ports
 
-# Networks returned by RPC getpeerinfo, defined in src/netbase.cpp::GetNetworkName()
-NET_UNROUTABLE = "unroutable"
+# Networks returned by RPC getpeerinfo.
+NET_UNROUTABLE = "not_publicly_routable"
 NET_IPV4 = "ipv4"
 NET_IPV6 = "ipv6"
 NET_ONION = "onion"

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ enum Network ParseNetwork(const std::string& net_in) {`
`55`	`55`	`std::string GetNetworkName(enum Network net)`
`56`	`56`	`{`
`57`	`57`	`switch (net) {`
`58`		`- case NET_UNROUTABLE: return "unroutable";`
	`58`	`+ case NET_UNROUTABLE: return "not_publicly_routable";`
`59`	`59`	`case NET_IPV4: return "ipv4";`
`60`	`60`	`case NET_IPV6: return "ipv6";`
`61`	`61`	`case NET_ONION: return "onion";`