[addrman] Remove AddrMan friends

jnewbery · jnewbery · commit a749fa539ae4 · 2021-11-09T17:09:50.000Z
AddrMan's friends both inherit from AddrMan, so just make the private
member protected and remove the friends.
diff --git a/src/addrman.h b/src/addrman.h
@@ -53,6 +53,7 @@ static constexpr int32_t DEFAULT_ADDRMAN_CONSISTENCY_CHECKS{0};
  */
 class AddrMan
 {
+protected:
     const std::unique_ptr<AddrManImpl> m_impl;
 
 public:
@@ -135,9 +136,6 @@ class AddrMan
     void SetServices(const CService& addr, ServiceFlags nServices);
 
     const std::vector<bool>& GetAsmap() const;
-
-    friend class AddrManTest;
-    friend class AddrManDeterministic;
 };
 
 #endif // BITCOIN_ADDRMAN_H
