tests: Rename test suits not following the test suite naming convention

practicalswift · practicalswift · commit 5fd864fe8a3b · 2018-03-19T08:54:07.000+01:00
The name of the fixture test suite in `src/test/foo_tests.cpp`
should be `foo_tests`.
diff --git a/src/test/blockchain_tests.cpp b/src/test/blockchain_tests.cpp
@@ -54,7 +54,7 @@ void TestDifficulty(uint32_t nbits, double expected_difficulty)
     RejectDifficultyMismatch(difficulty, expected_difficulty);
 }
 
-BOOST_FIXTURE_TEST_SUITE(blockchain_difficulty_tests, BasicTestingSetup)
+BOOST_FIXTURE_TEST_SUITE(blockchain_tests, BasicTestingSetup)
 
 BOOST_AUTO_TEST_CASE(get_difficulty_for_very_low_target)
 {
diff --git a/src/test/prevector_tests.cpp b/src/test/prevector_tests.cpp
@@ -13,7 +13,7 @@
 
 #include <boost/test/unit_test.hpp>
 
-BOOST_FIXTURE_TEST_SUITE(PrevectorTests, TestingSetup)
+BOOST_FIXTURE_TEST_SUITE(prevector_tests, TestingSetup)
 
 template<unsigned int N, typename T>
 class prevector_tester {
diff --git a/src/wallet/crypter.h b/src/wallet/crypter.h
@@ -67,15 +67,15 @@ class CMasterKey
 
 typedef std::vector<unsigned char, secure_allocator<unsigned char> > CKeyingMaterial;
 
-namespace wallet_crypto
+namespace crypto_tests
 {
     class TestCrypter;
 }
 
 /** Encryption/decryption context with key information */
 class CCrypter
 {
-friend class wallet_crypto::TestCrypter; // for test access to chKey/chIV
+friend class crypto_tests::TestCrypter; // for test access to chKey/chIV
 private:
     std::vector<unsigned char, secure_allocator<unsigned char>> vchKey;
     std::vector<unsigned char, secure_allocator<unsigned char>> vchIV;
diff --git a/src/wallet/test/coinselector_tests.cpp b/src/wallet/test/coinselector_tests.cpp
@@ -13,7 +13,7 @@
 #include <boost/test/unit_test.hpp>
 #include <random>
 
-BOOST_FIXTURE_TEST_SUITE(coin_selection_tests, WalletTestingSetup)
+BOOST_FIXTURE_TEST_SUITE(coinselector_tests, WalletTestingSetup)
 
 // how many times to run all the tests to have a chance to catch errors that only show up with particular random shuffles
 #define RUN_TESTS 100
diff --git a/src/wallet/test/crypto_tests.cpp b/src/wallet/test/crypto_tests.cpp
@@ -10,7 +10,7 @@
 
 #include <boost/test/unit_test.hpp>
 
-BOOST_FIXTURE_TEST_SUITE(wallet_crypto, BasicTestingSetup)
+BOOST_FIXTURE_TEST_SUITE(crypto_tests, BasicTestingSetup)
 
 class TestCrypter
 {

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ void TestDifficulty(uint32_t nbits, double expected_difficulty)`
`54`	`54`	`RejectDifficultyMismatch(difficulty, expected_difficulty);`
`55`	`55`	`}`
`56`	`56`
`57`		`-BOOST_FIXTURE_TEST_SUITE(blockchain_difficulty_tests, BasicTestingSetup)`
	`57`	`+BOOST_FIXTURE_TEST_SUITE(blockchain_tests, BasicTestingSetup)`
`58`	`58`
`59`	`59`	`BOOST_AUTO_TEST_CASE(get_difficulty_for_very_low_target)`
`60`	`60`	`{`
Original file line number	Diff line number	Diff line change
`@@ -67,15 +67,15 @@ class CMasterKey`
`67`	`67`
`68`	`68`	`typedef std::vector<unsigned char, secure_allocator<unsigned char> > CKeyingMaterial;`
`69`	`69`
`70`		`-namespace wallet_crypto`
	`70`	`+namespace crypto_tests`
`71`	`71`	`{`
`72`	`72`	`class TestCrypter;`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`/** Encryption/decryption context with key information */`
`76`	`76`	`class CCrypter`
`77`	`77`	`{`
`78`		`-friend class wallet_crypto::TestCrypter; // for test access to chKey/chIV`
	`78`	`+friend class crypto_tests::TestCrypter; // for test access to chKey/chIV`
`79`	`79`	`private:`
`80`	`80`	`std::vector<unsigned char, secure_allocator<unsigned char>> vchKey;`
`81`	`81`	`std::vector<unsigned char, secure_allocator<unsigned char>> vchIV;`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`
`11`	`11`	`#include <boost/test/unit_test.hpp>`
`12`	`12`
`13`		`-BOOST_FIXTURE_TEST_SUITE(wallet_crypto, BasicTestingSetup)`
	`13`	`+BOOST_FIXTURE_TEST_SUITE(crypto_tests, BasicTestingSetup)`
`14`	`14`
`15`	`15`	`class TestCrypter`
`16`	`16`	`{`