[addrman] Rename Add_() to AddSingle()

jnewbery · jnewbery · commit 2658eb6d6846 · 2021-10-28T12:52:27.000+01:00
diff --git a/src/addrman.cpp b/src/addrman.cpp
@@ -592,7 +592,7 @@ void AddrManImpl::Good_(const CService& addr, bool test_before_evict, int64_t nT
     }
 }
 
-bool AddrManImpl::Add_(const CAddress& addr, const CNetAddr& source, int64_t nTimePenalty)
+bool AddrManImpl::AddSingle(const CAddress& addr, const CNetAddr& source, int64_t nTimePenalty)
 {
     AssertLockHeld(cs);
 
@@ -1034,7 +1034,7 @@ bool AddrManImpl::Add(const std::vector<CAddress>& vAddr, const CNetAddr& source
     int nAdd = 0;
     Check();
     for (std::vector<CAddress>::const_iterator it = vAddr.begin(); it != vAddr.end(); it++)
-        nAdd += Add_(*it, source, nTimePenalty) ? 1 : 0;
+        nAdd += AddSingle(*it, source, nTimePenalty) ? 1 : 0;
     Check();
     if (nAdd) {
         LogPrint(BCLog::ADDRMAN, "Added %i addresses from %s: %i tried, %i new\n", nAdd, source.ToString(), nTried, nNew);
diff --git a/src/addrman_impl.h b/src/addrman_impl.h
@@ -244,7 +244,9 @@ class AddrManImpl
 
     void Good_(const CService& addr, bool test_before_evict, int64_t time) EXCLUSIVE_LOCKS_REQUIRED(cs);
 
-    bool Add_(const CAddress& addr, const CNetAddr& source, int64_t nTimePenalty) EXCLUSIVE_LOCKS_REQUIRED(cs);
+    /** Attempt to add a single address to addrman's new table.
+     *  @see AddrMan::Add() for parameters. */
+    bool AddSingle(const CAddress& addr, const CNetAddr& source, int64_t nTimePenalty) EXCLUSIVE_LOCKS_REQUIRED(cs);
 
     void Attempt_(const CService& addr, bool fCountFailure, int64_t nTime) EXCLUSIVE_LOCKS_REQUIRED(cs);
 

Original file line number	Diff line number	Diff line change
`@@ -592,7 +592,7 @@ void AddrManImpl::Good_(const CService& addr, bool test_before_evict, int64_t nT`
`592`	`592`	`}`
`593`	`593`	`}`
`594`	`594`
`595`		`-bool AddrManImpl::Add_(const CAddress& addr, const CNetAddr& source, int64_t nTimePenalty)`
	`595`	`+bool AddrManImpl::AddSingle(const CAddress& addr, const CNetAddr& source, int64_t nTimePenalty)`
`596`	`596`	`{`
`597`	`597`	`AssertLockHeld(cs);`
`598`	`598`
`@@ -1034,7 +1034,7 @@ bool AddrManImpl::Add(const std::vector<CAddress>& vAddr, const CNetAddr& source`
`1034`	`1034`	`int nAdd = 0;`
`1035`	`1035`	`Check();`
`1036`	`1036`	`for (std::vector<CAddress>::const_iterator it = vAddr.begin(); it != vAddr.end(); it++)`
`1037`		`- nAdd += Add_(*it, source, nTimePenalty) ? 1 : 0;`
	`1037`	`+ nAdd += AddSingle(*it, source, nTimePenalty) ? 1 : 0;`
`1038`	`1038`	`Check();`
`1039`	`1039`	`if (nAdd) {`
`1040`	`1040`	`LogPrint(BCLog::ADDRMAN, "Added %i addresses from %s: %i tried, %i new\n", nAdd, source.ToString(), nTried, nNew);`