cmd-list: Fix nested aliases, restore alias 'sit': 'cit' (#20513)

mmermerkaya · zkat · commit 91ef93691a9d · 2018-05-16T11:09:52.000-07:00
PR-URL: npm/npm#20513 Credit: @mmermerkaya Reviewed-By: @zkat
diff --git a/lib/config/cmd-list.js b/lib/config/cmd-list.js
@@ -46,7 +46,7 @@ var affordances = {
   'rm': 'uninstall',
   'r': 'uninstall',
   'rum': 'run-script',
-  'sit': 'install-ci-test',
+  'sit': 'cit',
   'urn': 'run-script'
 }
 
diff --git a/lib/npm.js b/lib/npm.js
@@ -191,7 +191,9 @@
     }
     if (plumbing.indexOf(c) !== -1) return c
     var a = abbrevs[c]
-    if (aliases[a]) a = aliases[a]
+    while (aliases[a]) {
+      a = aliases[a]
+    }
     return a
   }
 

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,9 @@`
`191`	`191`	`}`
`192`	`192`	`if (plumbing.indexOf(c) !== -1) return c`
`193`	`193`	`var a = abbrevs[c]`
`194`		`- if (aliases[a]) a = aliases[a]`
	`194`	`+ while (aliases[a]) {`
	`195`	`+ a = aliases[a]`
	`196`	`+ }`
`195`	`197`	`return a`
`196`	`198`	`}`
`197`	`199`