.. toctree:: :maxdepth: 1 :hidden: integration_tests.rst
Cloud-init has both unit tests and integration tests. Unit tests can
be found at :file:`tests/unittests`. Integration tests can be found at
:file:`tests/integration_tests`. Documentation specifically for integration
tests can be found on the :ref:`integration_tests` page, but
the guidelines specified below apply to both types of tests.
Cloud-init uses pytest to run its tests, and has tests written both
as unittest.TestCase sub-classes and as un-subclassed pytest tests.
The following guidelines should be followed.
- For ease of organisation and greater accessibility for developers unfamiliar
with
pytest, allcloud-initunit tests must be contained within test classes. In other words, module-level test functions should not be used. - Since all tests are contained within classes, it is acceptable to mix
TestCasetest classes andpytesttest classes within the same test file.- These can be easily distinguished by their definition:
pytestclasses will not use inheritance at all (e.g., TestGetPackageMirrorInfo), whereasTestCaseclasses will subclass (indirectly) fromTestCase(e.g., TestPrependBaseCommands).
- These can be easily distinguished by their definition:
- Unit tests and integration tests are located under :file:`cloud-init/tests`.
- For consistency, unit test files should have a matching name and directory location under :file:`tests/unittests`.
- E.g., the expected test file for code in :file:`cloudinit/path/to/file.py` is :file:`tests/unittests/path/to/test_file.py`.
pytesttest classes should use pytest fixtures to share functionality instead of inheritance.pytesttests should use bareassertstatements, to take advantage ofpytest's assertion introspection.
As we still support Ubuntu 18.04 (Bionic Beaver), we can only use pytest
features that are available in v3.3.2. This is an inexhaustive list of
ways in which this may catch you out:
- Only the following built-in fixtures are available [1]:
cachecapfdcapfdbinarycaplogcapsyscapsysbinarydoctest_namespacemonkeypatchpytestconfigrecord_xml_propertyrecwarntmpdir_factorytmpdir
- Variables/parameter names for
MockorMagicMockinstances should start withm_to clearly distinguish them from non-mock variables. For example,m_readurl(which would be a mock forreadurl). - The
assert_*methods that are available onMockandMagicMockobjects should be avoided, as typos in these method names may not raiseAttributeError(and so can cause tests to silently pass).- An important exception: if a
Mockis autospecced then misspelled assertion methods will raise anAttributeError, so these assertion methods may be used on autospeccedMockobjects.
- An important exception: if a
- For a non-autospecced
Mock, these substitutions can be used (mis assumed to be aMock):m.assert_any_call(*args, **kwargs)=>assert mock.call(*args, **kwargs) in m.call_args_listm.assert_called()=>assert 0 != m.call_countm.assert_called_once()=>assert 1 == m.call_countm.assert_called_once_with(*args, **kwargs)=>assert [mock.call(*args, **kwargs)] == m.call_args_listm.assert_called_with(*args, **kwargs)=>assert mock.call(*args, **kwargs) == m.call_args_list[-1]m.assert_has_calls(call_list, any_order=True)=>for call in call_list: assert call in m.call_args_listm.assert_has_calls(...)andm.assert_has_calls(..., any_order=False)are not easily replicated in a single statement, so their use when appropriate is acceptable.
m.assert_not_called()=>assert 0 == m.call_count
- When there are multiple patch calls in a test file for the module it
is testing, it may be desirable to capture the shared string prefix
for these patch calls in a module-level variable. If used, such
variables should be named
M_PATHor, for datasource tests,DS_PATH.
- Test arguments should be ordered as follows:
mock.patcharguments. When used as a decorator,mock.patchpartially applies its generatedMockobject as the first argument, so these arguments must go first.pytest.mark.parametrizearguments, in the order specified to theparametrizedecorator. These arguments are also provided by a decorator, so it's natural that they sit next to themock.patcharguments.- Fixture arguments, alphabetically. These are not provided by a decorator, so they are last, and their order has no defined meaning, so we default to alphabetical.
- It follows from this ordering of test arguments (so that we retain
the property that arguments left-to-right correspond to decorators
bottom-to-top) that test decorators should be ordered as follows:
pytest.mark.parametrizemock.patch
| [1] | This list of fixtures (with markup) can be reproduced by running: python3 -m pytest --fixtures -q | grep "^[^ -]" | grep -v 'no tests ran in' | sort | sed 's/ \[session scope\]//g;s/.*/* ``\0``/g' in an ubuntu lxd container with python3-pytest installed. |