Repository navigation
fix(context): make log_error honor --quiet regardless of stdout tty - #1984
Open
yunaremaia wants to merge 1 commit into
Open
yunaremaia wants to merge 1 commit into
yunaremaia wants to merge 1 commit into
Conversation
log_error gated the quiet check on stdout_isatty, so warnings/errors were always printed to the original stderr when stdout was redirected, ignoring --quiet. Mirror apply_warnings_filter and check only the quiet threshold. Closes httpie#1978.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1978. log_error gated the quiet check on stdout_isatty, so warnings/errors were always printed to the original stderr when stdout was redirected. Mirror apply_warnings_filter and check only the quiet threshold. Tests: tests/test_context.py pass.