Normalize Content-Length header to int#1691
Open
joshmuepu wants to merge 1 commit intohttpie:masterfrom
Open
Conversation
Author
|
CI failures appear unrelated to this change. I reproduced the Big5 encoding failures locally and they also fail across Linux, macOS, and Windows in CI. The changes in this PR are limited to Content-Length normalization in uploads.py and do not affect encoding or CLI argument parsing paths. Happy to rebase or adjust if you’d prefer this to land after CI issues are addressed upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change normalizes
Content-Lengthheader values before upload preparation so that values provided as strings or bytes are converted to an integer early and consistently.This prevents incorrect buffering and streaming behavior when
Content-Lengthis present but not anint.Details
Content-Lengthvalues tointwhen possibleValueErrorfor invalid values instead of silently continuingTests
Notes
While running the full test suite locally, I observed failures in
tests/test_encoding.pyrelated to Big5 charset detection that appear to be environment-specific and unrelated to this change.