Declare implicit dependency on Six 1.9 or higher#301
Conversation
|
I need this for #294. |
|
It would be nice to have a test job that explicitly requires and uses six 1.4 , so that newer features are not inadvertently used without upgrading the requirement. |
|
@jayvdb That sounds like a great idea, I'm not really sure how to go about doing that though. |
|
You could add a job with env:
- USE_OPTIONAL=true
- USE_OPTIONAL=false
+ - USE_SIX_14=trueAnd then in |
|
@jayvdb It appears the minimum required version is actually 1.9. Good call on the testing thing. I'll squash these commits and do a force push |
amorde
changed the title
|
In addition to the Travis errors described in #298, you are introducing many additional Travis jobs per build. This problem only requires one additional job. |
jayvdb
left a comment
jayvdb
left a comment
There was a problem hiding this comment.
Unnecessary jobs created.
jayvdb
left a comment
jayvdb
left a comment
There was a problem hiding this comment.
The commits probably need squashing.
| env: | ||
| - USE_OPTIONAL=true | ||
| - USE_OPTIONAL=false | ||
| - USE_SIX_LOWEST_VERSION=1.9 USE_OPTIONAL=true |
There was a problem hiding this comment.
USE_SIX_LOWEST_VERSION is very long. Could be shorter.
There was a problem hiding this comment.
Changed to SIX_VERSION
|
Hey @jayvdb, any updates on this? |
|
@jayvdb gotcha, haha sorry for the mixup! |
|
Thanks for the reviewing, @jayvdb! :) Ultimately, we should almost certainly declare (and test) minimum required versions for all our dependencies. |
3 participants
This project uses a syntax for importing urllib.parse from six which was introduced in Six version 1.4
The import can be found here
The relevant change in Six can be found here
This can cause an issue if a project has a previous version of Six (say version 1.3) installed when installing html5lib
EDIT:
importing
viewkeysin html5parser.py requires six 1.9