Skip to content

Also fix #127 with addinfourl#134

Closed
SimonSapin wants to merge 1 commit intohtml5lib:masterfrom
SimonSapin:python-bug20007
Closed

Also fix #127 with addinfourl#134
SimonSapin wants to merge 1 commit intohtml5lib:masterfrom
SimonSapin:python-bug20007

Conversation

@SimonSapin
Copy link
Copy Markdown
Contributor

@hoppipolla-critic-bot
Copy link
Copy Markdown

Critic review: https://critic.hoppipolla.co.uk/r/490

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@mattaustin
Copy link
Copy Markdown

I tested this in my app which used FancyURLOpener().open(), and returned a urllib.response.addinfourl instance. using Python 3.3 (Python 2.7 and 3.2 were unaffected), before the patch, the parser returned an empty html document. Afterwards it returned the expected content. Thanks @SimonSapin

@gsnedders
Copy link
Copy Markdown
Member

As I said on IRC to @SimonSapin: Can we change this to just pass a firstChunk into HTMLUnicodeInputStream and HTMLBinaryInputStream, so we can work around all 20007 issues all at one? It's ugly, but it stops endless isinstance checks for this.

@gsnedders gsnedders closed this Dec 27, 2013
SimonSapin added a commit to SimonSapin/html5lib-python that referenced this pull request Dec 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants