refactor(request_service): clean up Faraday leftovers and modernize hotpaths - #507
Merged
gildesmarais merged 1 commit intoSep 6, 2026
Merged
Conversation
gildesmarais
commented
Sep 6, 2026
gildesmarais
commented
Member
- Purge obsolete Faraday references in docs, contracts, and specs while preserving the :faraday migration bridge
- Simplify Strategy and HttpxStrategy by removing legacy streaming response_guard indirection and unused parameters
- Streamline CompressedBody content-encoding extraction using single-pass filter_map
- Deduplicate header stringification logic across BotasaurusContract and Response
- Optimize Article options validation with a frozen Set and streamline Deduplicator fingerprint checks
- Eliminate intermediate Hash allocations in FeedBuilder::Rss text attribute assignments
…otpaths - Purge obsolete Faraday references in docs, contracts, and specs while preserving the :faraday migration bridge - Simplify Strategy and HttpxStrategy by removing legacy streaming response_guard indirection and unused parameters - Streamline CompressedBody content-encoding extraction using single-pass filter_map - Deduplicate header stringification logic across BotasaurusContract and Response - Optimize Article options validation with a frozen Set and streamline Deduplicator fingerprint checks - Eliminate intermediate Hash allocations in FeedBuilder::Rss text attribute assignments
gildesmarais
deleted the
refactor/modernize-hotpath-and-faraday-cleanup
branch
September 6, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.