feat(auto_source): expand JsonState framework globals - #317
Merged
Merged
Conversation
gildesmarais
force-pushed
the
feat/json-state-extension-matcher
branch
from
March 9, 2026 21:00
4f309aa to
4c4748c
Compare
gildesmarais
changed the title
gildesmarais
marked this pull request as ready for review
March 9, 2026 21:03
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request expands the support for detecting and extracting article data from various JavaScript framework global state variables embedded in HTML. The main change is the addition of several new global assignment patterns in the
JsonStatescraper, along with new tests and a fixture to ensure these are correctly handled.Enhancements to framework global state detection:
GLOBAL_ASSIGNMENT_PATTERNSinJsonStateto include detection for Redux, Apollo, Remix, SvelteKit, Gatsby, Ember, and Angular global state variables, in addition to existing patterns.Testing improvements:
redux.htmlcontaining a sample of Redux-style preloaded state for testing.