Fix shadowing issue in sema.h #1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarzec
commented
Jun 20, 2024
Comment on lines
+1514
to
+1519
| const std::function emit_error = [this](source_position pos, std::string_view msg) { | ||
| errors.emplace_back(pos, msg); | ||
| }; | ||
| const std::function skip_error = [](source_position, std::string_view){}; | ||
|
|
||
| const auto handle_error = emit_errors ? emit_error : skip_error; |
Contributor
Author
There was a problem hiding this comment.
I chose to use two lambdas to make the emit_errors == false more explicitly no-op.
Owner
|
Thanks! Now I see that message in my local build, I must have forgotten to locally test self-build before checking that in. Thanks for the catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue causing the multiplatform build test to fail on Windows runners on GitHub.
The MSVC compiler generates a warning about a local variable shadowing a member. The warning is treated as an error in accordance with the test settings.
The Windows regression test is fixed by #1127.