Skip to content

to_cpp1: Remove missing initializer assert #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sookach wants to merge 1 commit into from
Closed

to_cpp1: Remove missing initializer assert #1124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/to_cpp1.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6719,7 +6719,9 @@ class cppfront

// Emit "auto" for deduced types (of course)
if (type->is_wildcard()) {
assert(n.initializer);
if(!n.initializer) {
return;
Copy link
Contributor

@gregmarr gregmarr Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be an error recorded here, like at line 6735?

Copy link
Contributor Author

@sookach sookach Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there would be a double reporting of the error since sema already records it.

cppfront/source/sema.h

Lines 1526 to 1529 in 442d17c

errors.emplace_back(
n.position(),
"an object with a deduced type must have an = initializer"
);

Copy link
Contributor Author

@sookach sookach Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good eye though

}
emit( *type, n.position() );
}
// Otherwise, emit the type
Expand Down