Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hotwired/turbo-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.13
Choose a base ref
...
head repository: hotwired/turbo-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.14
Choose a head ref
  • 14 commits
  • 16 files changed
  • 13 contributors

Commits on Mar 3, 2025

  1. Fix unwanted model retention when using class methods from `Turbo::Br… 

    …oadcastable` with locals (#710)

Consider the following model:

```ruby
class MyModel < ApplicationRecord
  broadcasts locals: { something_static: true }
end
```

When broadcasting for the first time without this fix, Broadcastable
does something like:

```
{ something_static }.reverse_merge!(my_model: #<MyModel: id=1>)
```

On the second broadcast for another model instance, the reverse merge
will be a no-op, because the first model is already in the Hash!

Switching to a non-destructive `reverse_merge` resolves the issue.
    @v-yarotsky
    v-yarotsky authored Mar 3, 2025
    Configuration menu
    Copy the full SHA
    bc499f9 View commit details
    Browse the repository at this point in the history

  2. add test missing assertion (#707)

    @adrienpoly
    adrienpoly authored Mar 3, 2025
    Configuration menu
    Copy the full SHA
    c36bab5 View commit details
    Browse the repository at this point in the history

  3. We dont need that many mutations

    David Heinemeier Hansson committed Mar 3, 2025
    Configuration menu
    Copy the full SHA
    a32d6cc View commit details
    Browse the repository at this point in the history

  4. Less still

    David Heinemeier Hansson committed Mar 3, 2025
    Configuration menu
    Copy the full SHA
    7c6e902 View commit details
    Browse the repository at this point in the history

  5. Fix typo in README.md (#704)

    @qmoya
    qmoya authored Mar 3, 2025
    Configuration menu
    Copy the full SHA
    a187ff3 View commit details
    Browse the repository at this point in the history

  6. Fix comment typo in gem documentation (#700)

    @benoittgt
    benoittgt authored Mar 3, 2025
    Configuration menu
    Copy the full SHA
    59e98c0 View commit details
    Browse the repository at this point in the history

  7. Test installer (#553) 

    * Test installer

This commit adds test coverage for the installer Rake task and application template. The installer is run against a freshly generated Rails app using the version of Rails that is currently loaded. Thus the installer can be tested with different versions of Rails in CI.

Similar to hotwired/stimulus-rails#136.

The motivation is to be able to move these tests from railties, see: rails/rails#49679

Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>

* Monkey-patch AppName#valid_const? on older Rails (< 7.1)

My hunch is that this was fixed in Rails 7.1 by rails/rails#46074, but I'm less concerned here because this test suite uses a Dummy app for all of the tests.

This is a problem I've been working on in rails/rails#50427, to remove the dummy applications and replace them with a generated app like we've done here with the installer test.

I'm happy to investigate replacing the dummy app here afterwards.

* Make sure only supported sqlite3 gem is installed

```
LoadError: Error loading the 'sqlite3' Active Record adapter. Missing a gem it depends on? can't activate sqlite3 (~> 1.4), already activated sqlite3-2.0.0-x86_64-linux-gnu. Make sure all dependencies are added to Gemfile. (LoadError)

Caused by:
Gem::LoadError: can't activate sqlite3 (~> 1.4), already activated sqlite3-2.0.0-x86_64-linux-gnu. Make sure all dependencies are added to Gemfile. (Gem::LoadError)

Tasks: TOP => db:test:prepare => db:load_config
(See full trace by running task with --trace)
/home/zzak/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/bundler-2.5.4/lib/bundler/rubygems_integration.rb:237:in `block (2 levels) in replace_gem': Error loading the 'sqlite3' Active Record adapter. Missing a gem it depends on? can't activate sqlite3 (~> 1.4), already activated sqlite3-2.0.0-x86_64-linux-gnu. Make sure all dependencies are added to Gemfile. (LoadError)
```

* Fix installer test for Rails 6.1

---------

Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
Co-authored-by: David Heinemeier Hansson <david@hey.com>
    @zzak @jonathanhefner @dhh
    3 people authored Mar 3, 2025
    Configuration menu
    Copy the full SHA
    dd6ab1b View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2025

  1. Update @rails/actioncable dependency to version >=7.0 (#705) 

    * Update @rails/actioncable dependency to version >=7.0

* yarn build
    @adrienpoly
    adrienpoly authored Mar 4, 2025
    Configuration menu
    Copy the full SHA
    8241ae3 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2025

  1. Include CSRF <meta> elements in frame layout (#697) 

    Closes [#669][]

If a response to a request with the `Turbo-Frame:` header does not
include the `<meta>` elements in the `<html>` document, it's likely that
the browser will remove any `<meta>` element present after handling
navigating the `<turbo-frame>` that originated the request.

In support of testing this behavior, this commit enables CSRF protection
in the test suite.
    @seanpdoyle
    seanpdoyle authored Mar 7, 2025
    Configuration menu
    Copy the full SHA
    94767d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2025

  1. Bump oven-sh/setup-bun from 1 to 2 

    Bumps [oven-sh/setup-bun](https://github.com/oven-sh/setup-bun) from 1 to 2.
- [Release notes](https://github.com/oven-sh/setup-bun/releases)
- [Commits](oven-sh/setup-bun@v1...v2)

---
updated-dependencies:
- dependency-name: oven-sh/setup-bun
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot
    dependabot[bot] authored Mar 10, 2025
    Configuration menu
    Copy the full SHA
    25c359b View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2025

  1. Merge pull request #722 from hotwired/dependabot/github_actions/oven-… 

    …sh/setup-bun-2

Bump oven-sh/setup-bun from 1 to 2
    @brunoprietog
    brunoprietog authored Apr 7, 2025
    Configuration menu
    Copy the full SHA
    3db32e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2025

  1. Fix stream_name calculation inside of thread (#727) 

    * Generate the stream name in the current thread

* Whitespace

* Revert to *streamables
    @brendon
    brendon authored Apr 9, 2025
    Configuration menu
    Copy the full SHA
    cb47713 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2025

  1. @hotwired/turbo-rails v8.0.14

    @jorgemanrubia
    jorgemanrubia committed Jun 2, 2025
    Configuration menu
    Copy the full SHA
    1ac14bd View commit details
    Browse the repository at this point in the history

  2. Bump version

    @jorgemanrubia
    jorgemanrubia committed Jun 2, 2025
    Configuration menu
    Copy the full SHA
    abb445e View commit details
    Browse the repository at this point in the history
Loading