feat: Forward Raw IncomingMessage and ServerResponse Via Env#129
Merged
yusukebe merged 4 commits intohonojs:mainfrom Jan 27, 2024
beeequeue:forward-incoming
Merged
feat: Forward Raw IncomingMessage and ServerResponse Via Env#129yusukebe merged 4 commits intohonojs:mainfrom beeequeue:forward-incoming
IncomingMessage and ServerResponse Via Env#129yusukebe merged 4 commits intohonojs:mainfrom
beeequeue:forward-incoming
Conversation
Member
|
Coool! I'll check it later. |
Member
|
Looks great! One thing, we could export the following export type Bindings = {
incoming: IncomingMessage
outgoing: ServerResponse
}I think users should import from import type { Bindings } from '@hono/node-server'cc: @Kyiro What do you think about this PR though I think you will say OK. |
- create and export `HttpBindings` and `Http2Bindings` - make `FetchCallback` not depend on `hono`
|
looks good to me |
yusukebe
changed the title
IncomingMessage and ServerResponse Via EnvIncomingMessage and ServerResponse Via Env
Member
|
I'll merge this now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the raw
IncomingMessageandServerResponseinstances accessible viac.envthe same way thathono/aws-lambdadoes it.After implementing it I saw that #90 does the same thing, but I thought I may as well submit it as it is smaller in scope.
Related: #80 #90 #122