-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Add Transmission get_torrents service and codeowner #42600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add Transmission get_torrents service and codeowner #42600
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds documentation for a new get_torrents action in the Transmission integration and adds the author as a code owner. The changes support the parent pull request that implements this new service in Home Assistant core.
Key changes:
- Documents the new
get_torrentsaction with parameters and usage example - Adds
@andrew-codechimpas a code owner for the Transmission integration
| | `entry_id` | no | The integration entry_id | | ||
| | `id` | no | ID of the torrent, can be found in the `torrent_info` attribute of the `*_torrents` sensors | | ||
|
|
||
| ### Action `get_torrents` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Action `get_torrents` | |
| ### Action: Get torrents |
|
|
||
| Gets torrent details for the selected filter. | ||
|
|
||
| This action populates [Response Data](/docs/scripts/perform-actions#use-templates-to-handle-response-data) with a dictionary of torrents based on the provided filter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This action populates [Response Data](/docs/scripts/perform-actions#use-templates-to-handle-response-data) with a dictionary of torrents based on the provided filter. | |
| The `get_torrents` action populates [Response Data](/docs/scripts/perform-actions#use-templates-to-handle-response-data) with a dictionary of torrents based on the provided filter. |
|
|
||
| This action populates [Response Data](/docs/scripts/perform-actions#use-templates-to-handle-response-data) with a dictionary of torrents based on the provided filter. | ||
|
|
||
| | Data attribute | Optional | Description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is the style that is used in the rest of the document, and what you are doing is consistent with the rest..
But we are trying to move towards the style used in this example here:
https://github.com/home-assistant/home-assistant.io/blob/current/source/_integrations/_integration_docs_template.markdown?plain=1#L139
- the title uses the UI string, not the YAML. the YAML is then used in the intro.
- The descriptive content is not in a table but uses a list instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's so much better than tables, thanks for the pointer.
I've moved all actions to this style.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
c0ffeeca7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @andrew-codechimp 👍
Proposed change
Add documentation for new action get_torrents
Add myself as a codeowner
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.