Skip to content

Conversation

@steinmn
Copy link
Contributor

@steinmn steinmn commented Nov 4, 2025

Proposed change

When using the energy_usage_this_month-entity in my energy dashboard, I got a large negative value at the start of the month, since the energy meter reset to 0 and the state class was total. This is the typical behavior of a total_increasing sensor, so switching sensor class to total_increasing will fix that.

The issue described in #154558 is quite similar, but I don't see a good solution for it: The other two energy sensor in the LG Thinq integration (energy_usage_yesterday and energy_usage_last_month) also currently have the sensor class total, but their usage seem more like measurement class sensors to me. When I tried changing it to that, however, I got the following warning and decided to just leave it for the time being:

Entity sensor.test_air_conditioner_energy_yesterday (<class 'homeassistant.components.lg_thinq.sensor.ThinQEnergySensorEntity'>) is using state class 'measurement' which is impossible considering device class ('energy') it is using; expected None or one of 'total', 'total_increasing';

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 4, 2025

Hey there @LG-ThinQ-Integration, mind taking a look at this pull request as it has been labeled with an integration (lg_thinq) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lg_thinq can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lg_thinq Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek added this to the 2025.11.0 milestone Nov 5, 2025
@joostlek joostlek merged commit 553ec35 into home-assistant:dev Nov 5, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants