codeql/python/ql/src/Classes/InitCallsSubclassMethod.py at main · hohn/codeql · GitHub

This repository was archived by the owner on Aug 18, 2022. It is now read-only.

48 lines (30 loc) · 937 Bytes

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

39

40

41

42

43

44

45

46

#Superclass __init__ calls subclass method

class Super(object):

def __init__(self, arg):

self._state = "Not OK"

self.set_up(arg)

self._state = "OK"

def set_up(self, arg):

"Do some set up"

class Sub(Super):

def __init__(self, arg):

Super.__init__(self, arg)

self.important_state = "OK"

def set_up(self, arg):

Super.set_up(self, arg)

"Do some more set up" # Dangerous as self._state is "Not OK"

#Improved version with inheritance:

class Super(object):

def __init__(self, arg):

self._state = "Not OK"

self.super_set_up(arg)

self._state = "OK"

def super_set_up(self, arg):

"Do some set up"

class Sub(Super):

def __init__(self, arg):

Super.__init__(self, arg)

self.sub_set_up(self, arg)

self.important_state = "OK"

def sub_set_up(self, arg):

"Do some more set up"