Skip to content

Unit tests#5

Open
rummik wants to merge 14 commits intohobbyquaker:masterfrom
rummik:unit-tests
Open

Unit tests#5
rummik wants to merge 14 commits intohobbyquaker:masterfrom
rummik:unit-tests

Conversation

@rummik
Copy link
Copy Markdown
Contributor

@rummik rummik commented Dec 21, 2017

  • Ready to merge

Ongoing work for unit tests.

Todo:

  • Add Grunt task for running Mocha tests
  • Finish writing tests

@hobbyquaker
Copy link
Copy Markdown
Owner

wow, super cool, you're hardworking! 👍 Thank you!
Looking forward to merge and use in my lirc2mqtt project :)

@rummik
Copy link
Copy Markdown
Contributor Author

rummik commented Dec 29, 2017

I just find writing tests to be kind of soothing 😋

@rummik
Copy link
Copy Markdown
Contributor Author

rummik commented Dec 29, 2018

Just realized I left this PR hanging last year. I've finished up the tests and added grunt-mocha-test, so it should be good to go now 👍

Edit: Also, the tests should ensure that backward compatibility with callback syntax is supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants