Repository navigation
fix(engine): verify WebGPU device creation before capture - #6343
Open
user-github-me wants to merge 1 commit into
Open
user-github-me wants to merge 1 commit into
user-github-me wants to merge 1 commit into
Conversation
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An available WebGPU adapter can still reject device creation. For compositions declaring
data-requires-webgpu, capture now checks that a temporary device can be created. Adapter and device requests share a ten-second deadline, and every created probe device is destroyed, including late completions.This completes the accepted device-check remainder of #5775, following the Windows DXC launch fix in #5830. The existing software-WebGPU policy still applies. The probe uses default device requirements; compositions request their own renderer-specific features and limits.
Validation: seven targeted regressions fail on the original source. The four focused engine suites pass 128 tests with one existing Linux-only skip on macOS. Full build, engine typecheck, lint/format, test reachability, normal commit hooks, comment checks and Mint documentation checks pass. Native Chrome 152 on macOS passes hardware device creation/cleanup and controlled device-rejection checks; the Windows DLL failure was not reproduced locally.
Fixes #5775