Skip to content

fix(tsconfig): include root and package tooling files in typechecked projects - #4385

Open
CatLover01 wants to merge 1 commit into
hey-api:mainfrom
CatLover01:fix/typescript-dx
Open

fix(tsconfig): include root and package tooling files in typechecked projects#4385
CatLover01 wants to merge 1 commit into
hey-api:mainfrom
CatLover01:fix/typescript-dx

Conversation

@CatLover01

@CatLover01 CatLover01 commented Aug 28, 2026

Copy link
Copy Markdown

Summary

Cover every TypeScript file with a tsconfig project so the editor and CI typecheck
the whole repo, not just src/.

  • Promote module: ESNext, resolveJsonModule, rewriteRelativeImportExtensions
    to tsconfig.base.json; drop per-package module/resolveJsonModule duplicates.
  • Relax each package's rootDir: "src" and list its tsdown*.config.ts,
    vitest.setup.ts, and package.json in include (composite projects require
    all imported files to be listed).
  • Root tsconfig.json now extends the base and typechecks scripts/ +
    vitest.config.ts; fixed a handful of strict-mode nits those files were never
    checked under.
  • Root configs for custom-client/vite-plugin/nuxt/types intentionally
    untouched.

DX-only. This changes no emitted artifacts — package output is produced by
tsdown (rolldown, target derived from engines.node) and @hey-api/types
(declarations only) — so no code shipped to consumers changes.

Certification

  • I have personally reviewed every line of this contribution and take responsibility for its correctness.

@bolt-new-by-stackblitz

bolt-new-by-stackblitz Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pullfrog

pullfrog Bot commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

<｜DSML｜tool_calls>
<｜DSML｜invoke name="pullfrog_select_mode">
<｜DSML｜parameter name="mode" string="true">Review</｜DSML｜parameter>
</｜DSML｜invoke>
</｜DSML｜tool_calls>

Pullfrog  ｜ ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot ｜ View workflow run ｜ via Pullfrog ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

@CatLover01 is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1d65cb7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hey-api

hey-api Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Pull request checklist

A few things need attention before this pull request can be merged:

  • No linked issue found. Reference at least one issue this pull request closes or relates to, using feat: codecov #123, owner/repo#123, or the full issue URL.

Update the description and this check re-runs automatically.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.56%. Comparing base (9d56b7e) to head (1d65cb7).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4385   +/-   ##
=======================================
  Coverage   40.56%   40.56%           
=======================================
  Files         827      827           
  Lines       25727    25727           
  Branches     7673     7687   +14     
=======================================
  Hits        10436    10436           
  Misses      12319    12319           
  Partials     2972     2972
Flag Coverage Δ
unittests 40.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Aug 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

@hey-api/codegen-cli

npm i https://pkg.pr.new/@hey-api/codegen-cli@4385

@hey-api/codegen-core

npm i https://pkg.pr.new/@hey-api/codegen-core@4385

@hey-api/json-schema-ref-parser

npm i https://pkg.pr.new/@hey-api/json-schema-ref-parser@4385

@hey-api/nuxt

npm i https://pkg.pr.new/@hey-api/nuxt@4385

@hey-api/openapi-python

npm i https://pkg.pr.new/@hey-api/openapi-python@4385

@hey-api/openapi-ts

npm i https://pkg.pr.new/@hey-api/openapi-ts@4385

@hey-api/shared

npm i https://pkg.pr.new/@hey-api/shared@4385

@hey-api/spec-types

npm i https://pkg.pr.new/@hey-api/spec-types@4385

@hey-api/types

npm i https://pkg.pr.new/@hey-api/types@4385

@hey-api/vite-plugin

npm i https://pkg.pr.new/@hey-api/vite-plugin@4385

commit: 1d65cb7

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@CatLover01