Skip to content

Conversation

@robinjhuang
Copy link

Hey! My name is Robin and I'm from comfy-org! We would love to have you join the Comfy Registry, a public collection of custom nodes which lets authors publish nodes by version and automate testing against existing workflows. This PR updates the Github Action publish.yml to ensure latest ComfyUI Community Standard.

Updates:

  1. Issue Creating Permission: Ensures that the workflow can open issues to report publishing states or warnings, facilitating better communication and issue tracking.
+ # auto issue permission, for Comfy CustomNode registry publishing state
+ permissions:
+   issues: write
  1. Conditional Execution: Only runs the publish job in author’s repo, defaults to repo owner, reference issue here: - Forks problem: add an organisation or owner check to run the action · Issue #2 · Comfy-Org/publish-node-action
-     if: github.event.repository.fork == false 
+     if: ${{ github.repository_owner == 'heshengtao' }}
  1. Versioning: We use explicit version number after stable release, using a stable release version of the action reduces the risk of unexpected behavior from changes in the action's main branch.
-     uses: Comfy-Org/publish-node-action@main
+     uses: Comfy-Org/publish-node-action@v1

Learn More

Please message me on Discord at robin or join our server server if you have any questions! For more information, visit the official Comfy-Org blog: ComfyUI Blog.

- Added permissions for issue writing in the workflow.
- Modified condition to check repository owner instead of fork status.
- Updated action version from `main` to `v1` for `publish-node-action`.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants