Skip to content

Conversation

@edmorley
Copy link
Member

Switches from the pip CLI arg --disable-pip-version-check to the env var PIP_DISABLE_PIP_VERSION_CHECK=1, since:

  • It ensures the unnecessary version check is disabled if the user calls pip outside the main buildpack install step too.
  • The env var is what the CNB is already using.

See:
https://pip.pypa.io/en/stable/cli/pip/#cmdoption-disable-pip-version-check

GUS-W-20289539.

@edmorley edmorley self-assigned this Nov 21, 2025
Switches from the pip CLI arg `--disable-pip-version-check` to the env
var `PIP_DISABLE_PIP_VERSION_CHECK=1`, since:
- It ensures the unnecessary version check is disabled if the user
  calls pip outside the main buildpack install step.
- The env var is what the CNB is already using.

See:
https://pip.pypa.io/en/stable/cli/pip/#cmdoption-disable-pip-version-check

GUS-W-20289539.
@edmorley edmorley force-pushed the disable-pip-version-check-env-var branch from e1f69c4 to ad0d76f Compare November 21, 2025 10:55
@edmorley edmorley marked this pull request as ready for review November 21, 2025 10:59
@edmorley edmorley requested a review from a team as a code owner November 21, 2025 10:59
@edmorley edmorley enabled auto-merge (squash) November 21, 2025 11:09
@edmorley edmorley merged commit d668dbe into main Nov 21, 2025
5 of 6 checks passed
@edmorley edmorley deleted the disable-pip-version-check-env-var branch November 21, 2025 11:17
@heroku-linguist heroku-linguist bot mentioned this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants