Skip to content

Fixed regex for null bytes character replacement #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edmorley merged 1 commit into from
Nov 17, 2025
Merged

Fixed regex for null bytes character replacement #1966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [Unreleased]

- Fixed regex for null bytes character replacement to replace all occurrences, not just the first. ([#1966](https://github.com/heroku/heroku-buildpack-python/pull/1966))

## [v319] - 2025-11-14

Expand Down
2 changes: 1 addition & 1 deletion lib/python_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ function python_version::read_trimmed_version_lines() {
--regexp-extended \
--expression 's/^[[:space:]]+//' \
--expression 's/[[:space:]]+$//' \
--expression 's/\x0/␀/' \
--expression 's/\x0/␀/g' \
--expression '/^(#|$)/d' \
"${file}"
}
Expand Down
Binary file modified spec/fixtures/runtime_txt_invalid_version/runtime.txt
View file
Open in desktop
Binary file not shown.