Conversation
Some PDFs are tagged as encrypted, even though they aren't encrypted, and will open without a password prompt in a GUI PDF reader. This change attempts to "decrypt" with a blank password, before prompting for a password.
hellerbarde
requested changes
Mar 30, 2022
Owner
hellerbarde
left a comment
hellerbarde
left a comment
There was a problem hiding this comment.
When I look at the original code, I dislike it very much, so I'd rather fix this weird while true construct which has no good way to cancel. If you'd be willing to look at it again, I'd be glad, but else I'll try to invest some time as soon as I can. Sorry for not waving it through, after not reacting for so long 🙈
Owner
|
Thank you so much for taking the time to submit a pull request though!! Sorry, I should have led with that. I'm a little tired right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some PDFs are tagged as encrypted, even though they aren't encrypted, and will open without a password prompt in a GUI PDF reader. This change attempts to "decrypt" with a blank password, before prompting for a password. This opens these troublesome files without a password prompt and allows stapler automation tasks to run.