Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: haskell/text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: haskell/text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature-sconcat-stimes
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 6 files changed
  • 1 contributor

Commits on Apr 22, 2025

  1. Add benchmarks for semigroup methods.

    @kindaro
    kindaro committed Apr 22, 2025
    Configuration menu
    Copy the full SHA
    47bbaf1 View commit details
    Browse the repository at this point in the history

  2. Add specialized implementation of semigroup methods.

    @kindaro
    kindaro committed Apr 22, 2025
    Configuration menu
    Copy the full SHA
    866e585 View commit details
    Browse the repository at this point in the history

  3. Check that stimes works right in corner cases.

    @kindaro
    kindaro committed Apr 22, 2025
    Configuration menu
    Copy the full SHA
    f7e1089 View commit details
    Browse the repository at this point in the history

  4. Make sure stimes works right in corner cases.

    @kindaro
    kindaro committed Apr 22, 2025
    Configuration menu
    Copy the full SHA
    e22e8d6 View commit details
    Browse the repository at this point in the history

  5. Be abstract of the implementation of Integer. 

    The constructors of `Integer` and the module they are exported from all
changed between GHC 8 and 9.
    @kindaro
    kindaro committed Apr 22, 2025
    Configuration menu
    Copy the full SHA
    37f2221 View commit details
    Browse the repository at this point in the history

  6. Make stimes crash on negative numbers. 

    Why? Li-yao Xia explains:

> 1. Asking to "replicate a string n times" with negative n is nonsense.
>    There must be an error in the definition of n, so throwing an
>    exception lets users be aware of that error and fix it.
> 2. The default definition of `stimes` already throws an exception for `n
>    <= 0`. People haven't complained about it. Extending the definition
>    for `n = 0` is reasonable for a monoid.
> 3. There could still be a case made in favor of making `stimes` less
>    partial and more similar to `replicate` (I think "replicate a string
>    n times" is nonsense as a sentence in natural language, but I don't
>    have a strong argument that code must follow natural language). Until
>    someone makes a good case for extending `stimes`, throwing an
>    exception for negative arguments is forward-compatible: we can extend
>    the function later (it would only break code that catches the
>    exception, a fishy thing to do). If we made it total now and changed
>    our minds later, that would be a more breaking change.

#580 (comment)
    @kindaro
    kindaro committed Apr 22, 2025
    Configuration menu
    Copy the full SHA
    4e2599f View commit details
    Browse the repository at this point in the history

  7. Move the crash warning to the instance haddock. 

    Haddock does not support comments on instance methods.

haskell/haddock#123
    @kindaro
    kindaro committed Apr 22, 2025
    Configuration menu
    Copy the full SHA
    9f63f10 View commit details
    Browse the repository at this point in the history
Loading