Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: haskell/hackage-security
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: haskell/hackage-security
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr/issue-196
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 1, 2018

  1. Move multipleExitPoints helper to H.S.Util.Exit module

    @hvr
    hvr committed Jan 1, 2018
    Configuration menu
    Copy the full SHA
    7934abc View commit details
    Browse the repository at this point in the history

  2. Add more sanity checks to incremental update of uncompressed index.tar 

    The current code blindly assumes that the pre-existing index.tar is a
prefix to the new uncompressed index.tar;

Besides the possibility of data corruption, the incremental
index.tar.gz update logic however supports update transactions which
can violate this assumption, resulting in a state where the index.tar
doesn't get updated or alternative gets corrupted for real.

This patch makes the heuristic for the incremental update of the
uncompressed index.tar more robust by including more sanity checks,
specifically testing that the tail of the old index.tar is contained
in the new index.tar data stream it is to be updated with. If these
new integrity checks fail, the code falls back to the (slower)
non-incremental full decompression codepath.

This is only a partial solution to #196.
    @hvr
    hvr committed Jan 1, 2018
    Configuration menu
    Copy the full SHA
    8e7c1bc View commit details
    Browse the repository at this point in the history
Loading