Fix out-of-bounds read in reject_contain, then drop redundant work in the rule engine - #4759
Open
matrix wants to merge 3 commits into
Open
Fix out-of-bounds read in reject_contain, then drop redundant work in the rule engine#4759matrix wants to merge 3 commits into
matrix wants to merge 3 commits into
Conversation
matrix
force-pushed
the
update_rule_engine_v1
branch
from
August 6, 2026 20:13
667b13a to
06e88ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reject_contain used strchr on "out", which is not a NUL terminated string but out_len bytes. A candidate containing 0x00 ended the search early, so the rules "!" and "/" rejected candidates that did contain the character and the scan runs past the end of the buffer whenever no zero byte happens to follow. memchr with out_len fixes both.
drops work the rule engine did not need: a heap allocation per call, and two buffer clears whose bytes are never read