Skip to content

Make testdata a sub-module of ld-decode for local tests #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simoninns merged 3 commits into from
Dec 9, 2025
Merged

Make testdata a sub-module of ld-decode for local tests #986

simoninns merged 3 commits into from
Dec 9, 2025

Conversation

@simoninns
Copy link
Collaborator

@simoninns simoninns commented Dec 9, 2025

Unless testdata is a sub-module the local testing fails.

The CI/CD actions in github worked as there was an explicit git clone action to pull in the test-data. With a sub-module that step isn't needed and testing works both on github and locally with the following command:

ctest --output-on-failure

This step is included in the BUILD.md documentation already (it just didn't work before).

This PR fixes issue #984 but the submodule download will be pretty slow until issue #985 is fixed and closed.

Example of local test output with sub-module:

$ ctest --output-on-failure
Test project /home/sdi/Coding/github/ld-decode-venv/ld-decode/build
      Start  1: chroma-ntsc-rgb
 1/16 Test  #1: chroma-ntsc-rgb ..................   Passed    5.03 sec
      Start  2: chroma-ntsc-ycbcr
 2/16 Test  #2: chroma-ntsc-ycbcr ................   Passed    4.11 sec
      Start  3: chroma-pal-rgb
 3/16 Test  #3: chroma-pal-rgb ...................   Passed    6.24 sec
      Start  4: chroma-pal-ycbcr
 4/16 Test  #4: chroma-pal-ycbcr .................   Passed    5.92 sec
      Start  5: ld-cut-ntsc
 5/16 Test  #5: ld-cut-ntsc ......................   Passed   24.04 sec
      Start  6: ld-cut-pal
 6/16 Test  #6: ld-cut-pal .......................   Passed    7.59 sec
      Start  7: decode-ntsc-cav
 7/16 Test  #7: decode-ntsc-cav ..................   Passed    5.22 sec
      Start  8: decode-ntsc-clv
 8/16 Test  #8: decode-ntsc-clv ..................   Passed    3.02 sec
      Start  9: decode-pal-cav
 9/16 Test  #9: decode-pal-cav ...................   Passed    3.53 sec
      Start 10: decode-pal-clv
10/16 Test #10: decode-pal-clv ...................   Passed    4.03 sec
      Start 11: ldf-reader-full
11/16 Test #11: ldf-reader-full ..................   Passed    0.19 sec
      Start 12: testfilter
12/16 Test #12: testfilter .......................   Passed    0.01 sec
      Start 13: testlinenumber
13/16 Test #13: testlinenumber ...................   Passed    0.01 sec
      Start 14: testmetadata
14/16 Test #14: testmetadata .....................   Passed    0.01 sec
      Start 15: testvbidecoder
15/16 Test #15: testvbidecoder ...................   Passed    0.01 sec
      Start 16: testvitcdecoder
16/16 Test #16: testvitcdecoder ..................   Passed    0.01 sec

100% tests passed, 0 tests failed out of 16

Total Test time (real) =  68.97 sec

@simoninns simoninns merged commit c20f1ef into happycube:main Dec 9, 2025
1 check passed
@simoninns simoninns deleted the testdata-202512 branch December 9, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@simoninns