Skip to content

Drop Qt5 from ld-decode-tools and enforce out-of-source building via cmake #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
happycube merged 7 commits into from
Dec 9, 2025
Merged

Drop Qt5 from ld-decode-tools and enforce out-of-source building via cmake #982

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef9c27b
Remove Qt5 from build and test environment
simoninns Dec 8, 2025
57459d1
Fix some Qt6 warnings coming from sqliteio.cpp
simoninns Dec 8, 2025
7e38264
Move cmake to an out-of-source build structure - Add documentation ar…
simoninns Dec 8, 2025
f40814b
Added missing link to contribution documentation
simoninns Dec 8, 2025
411d64f
Standardize on cmake 3.16 minimum version
simoninns Dec 8, 2025
231e1eb
Remove random .tmp file and update gitignore to stop it happening again
simoninns Dec 8, 2025
5b1b8a4
Add additional checks into cmake to force out-of-source builds
simoninns Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix some Qt6 warnings coming from sqliteio.cpp
  • Loading branch information
@simoninns
simoninns committed Dec 8, 2025
commit 57459d18f9cb84b9ab332b459a3813feb1b9df01
12 changes: 6 additions & 6 deletions tools/library/tbc/sqliteio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,8 @@ int SqliteWriter::writeCaptureMetadata(const QString &system, const QString &dec

query.addBindValue(system);
query.addBindValue(decoder);
query.addBindValue(gitBranch.isEmpty() ? QVariant(QVariant::String) : gitBranch);
query.addBindValue(gitCommit.isEmpty() ? QVariant(QVariant::String) : gitCommit);
query.addBindValue(gitBranch.isEmpty() ? QVariant() : gitBranch);
query.addBindValue(gitCommit.isEmpty() ? QVariant() : gitCommit);
query.addBindValue(videoSampleRate);
query.addBindValue(activeVideoStart);
query.addBindValue(activeVideoEnd);
Expand All @@ -512,7 +512,7 @@ int SqliteWriter::writeCaptureMetadata(const QString &system, const QString &dec
query.addBindValue(isWidescreen ? 1 : 0);
query.addBindValue(white16bIre);
query.addBindValue(black16bIre);
query.addBindValue(captureNotes.isEmpty() ? QVariant(QVariant::String) : captureNotes);
query.addBindValue(captureNotes.isEmpty() ? QVariant() : captureNotes);

if (!query.exec()) {
tbcDebugStream() << "Failed to insert capture metadata:" << query.lastError().text();
Expand Down Expand Up @@ -540,8 +540,8 @@ bool SqliteWriter::updateCaptureMetadata(int captureId, const QString &system, c

query.addBindValue(system);
query.addBindValue(decoder);
query.addBindValue(gitBranch.isEmpty() ? QVariant(QVariant::String) : gitBranch);
query.addBindValue(gitCommit.isEmpty() ? QVariant(QVariant::String) : gitCommit);
query.addBindValue(gitBranch.isEmpty() ? QVariant() : gitBranch);
query.addBindValue(gitCommit.isEmpty() ? QVariant() : gitCommit);
query.addBindValue(videoSampleRate);
query.addBindValue(activeVideoStart);
query.addBindValue(activeVideoEnd);
Expand All @@ -555,7 +555,7 @@ bool SqliteWriter::updateCaptureMetadata(int captureId, const QString &system, c
query.addBindValue(isWidescreen ? 1 : 0);
query.addBindValue(white16bIre);
query.addBindValue(black16bIre);
query.addBindValue(captureNotes.isEmpty() ? QVariant(QVariant::String) : captureNotes);
query.addBindValue(captureNotes.isEmpty() ? QVariant() : captureNotes);
query.addBindValue(captureId);

if (!query.exec()) {
Expand Down